Skip to content

Conversation

@hy-NJU
Copy link

@hy-NJU hy-NJU commented Nov 5, 2025

Summary:
In this test, we run following step

  1. Create a DramKVInferenceEmbedding with TTL eviction for 1 min
  2. Insert 1 embedding with current Unixtime - 2 mins (it is already expired) as timestamp
  3. Read from it and check correctness
  4. Read for multiple times
  5. Evict it
  6. Read it --- this time should be inconsistent

Reviewed By: emlin

Differential Revision: D86268606

@netlify
Copy link

netlify bot commented Nov 5, 2025

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 111548c
🔍 Latest deploy log https://app.netlify.com/projects/pytorch-fbgemm-docs/deploys/690b6cd4b45c2b00082fa224
😎 Deploy Preview https://deploy-preview-5091--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Summary:
X-link: facebookresearch/FBGEMM#2099

In this test, we run following step
1. Create a DramKVInferenceEmbedding with TTL eviction for 1 min
2. Insert 1 embedding with current Unixtime - 2 mins (it is already expired) as timestamp
3. Read from it and check correctness
4. Read for multiple times
5. Evict it
6. Read it --- this time should be inconsistent

Reviewed By: emlin

Differential Revision: D86268606
@meta-codesync
Copy link
Contributor

meta-codesync bot commented Nov 5, 2025

@hy-NJU has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86268606.

@meta-codesync
Copy link
Contributor

meta-codesync bot commented Nov 5, 2025

This pull request has been merged in 7f4a9d2.

Bernard-Liu pushed a commit to ROCm/FBGEMM that referenced this pull request Nov 11, 2025
Summary:
Pull Request resolved: pytorch#5091

X-link: https://github.com/facebookresearch/FBGEMM/pull/2099

In this test, we run following step
1. Create a DramKVInferenceEmbedding with TTL eviction for 1 min
2. Insert 1 embedding with current Unixtime - 2 mins (it is already expired) as timestamp
3. Read from it and check correctness
4. Read for multiple times
5. Evict it
6. Read it --- this time should be inconsistent

Reviewed By: emlin

Differential Revision: D86268606

fbshipit-source-id: edc2dc24e5327399421d20229a0b1af2ca29ea7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants