Skip to content

Incorrect typing for click.echo_via_pager #3089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chronitis opened this issue Jun 26, 2019 · 2 comments · Fixed by #3090
Closed

Incorrect typing for click.echo_via_pager #3089

chronitis opened this issue Jun 26, 2019 · 2 comments · Fixed by #3090
Labels
stubs: false positive Type checkers report false errors

Comments

@chronitis
Copy link
Contributor

chronitis commented Jun 26, 2019 •
edited
Loading

The signature for click.echo_via_pager was updated incorrectly in 018ecb3 (third_party/2and3/click/termui.pyi:65) - the default parameter for the second argument was dropped, so mypy is now (incorrectly) reporting a single-argument invocation as wrong.

The signature should correspond to:

click.echo_via_pager(text_or_generator, color=None)
@srittau srittau added size-small stubs: false positive Type checkers report false errors labels Jun 26, 2019
@srittau
Copy link
Collaborator

srittau commented Jun 26, 2019

Thanks, patches welcome!

Cc @cs-shadow

@chronitis chronitis mentioned this issue Jun 26, 2019
Merged
@chronitis
Copy link
Contributor Author

@srittau patch in #3090

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stubs: false positive Type checkers report false errors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore default value to click.echo_via_pager chronitis/typeshed
2 participants
@srittau @chronitis