Skip to content

Commit ae15dd3

Browse files
Restore the deprecated logging.warn() in 3.13 (#12509)
1 parent 815d8bf commit ae15dd3

File tree

2 files changed

+37
-36
lines changed

2 files changed

+37
-36
lines changed

stdlib/@tests/stubtest_allowlists/py313.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -194,3 +194,9 @@ codecs.xmlcharrefreplace_errors
194194

195195
# To match `dict`, we lie about the runtime, but use overloads to match the correct behavior
196196
types.MappingProxyType.get
197+
198+
# logging.warn() was restored after the 3.13 release candidate, which is what CI is using
199+
logging.__all__
200+
logging.Logger.warn
201+
logging.LoggerAdapter.warn
202+
logging.warn

stdlib/logging/__init__.pyi

Lines changed: 31 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,9 @@ __all__ = [
5555
"setLogRecordFactory",
5656
"lastResort",
5757
"raiseExceptions",
58+
"warn",
5859
]
5960

60-
if sys.version_info < (3, 13):
61-
__all__ += ["warn"]
6261
if sys.version_info >= (3, 11):
6362
__all__ += ["getLevelNamesMapping"]
6463
if sys.version_info >= (3, 12):
@@ -157,17 +156,16 @@ class Logger(Filterer):
157156
stacklevel: int = 1,
158157
extra: Mapping[str, object] | None = None,
159158
) -> None: ...
160-
if sys.version_info < (3, 13):
161-
def warn(
162-
self,
163-
msg: object,
164-
*args: object,
165-
exc_info: _ExcInfoType = None,
166-
stack_info: bool = False,
167-
stacklevel: int = 1,
168-
extra: Mapping[str, object] | None = None,
169-
) -> None: ...
170-
159+
@deprecated("Deprecated; use warning() instead.")
160+
def warn(
161+
self,
162+
msg: object,
163+
*args: object,
164+
exc_info: _ExcInfoType = None,
165+
stack_info: bool = False,
166+
stacklevel: int = 1,
167+
extra: Mapping[str, object] | None = None,
168+
) -> None: ...
171169
def error(
172170
self,
173171
msg: object,
@@ -412,18 +410,17 @@ class LoggerAdapter(Generic[_L]):
412410
extra: Mapping[str, object] | None = None,
413411
**kwargs: object,
414412
) -> None: ...
415-
if sys.version_info < (3, 13):
416-
def warn(
417-
self,
418-
msg: object,
419-
*args: object,
420-
exc_info: _ExcInfoType = None,
421-
stack_info: bool = False,
422-
stacklevel: int = 1,
423-
extra: Mapping[str, object] | None = None,
424-
**kwargs: object,
425-
) -> None: ...
426-
413+
@deprecated("Deprecated; use warning() instead.")
414+
def warn(
415+
self,
416+
msg: object,
417+
*args: object,
418+
exc_info: _ExcInfoType = None,
419+
stack_info: bool = False,
420+
stacklevel: int = 1,
421+
extra: Mapping[str, object] | None = None,
422+
**kwargs: object,
423+
) -> None: ...
427424
def error(
428425
self,
429426
msg: object,
@@ -523,17 +520,15 @@ def warning(
523520
stacklevel: int = 1,
524521
extra: Mapping[str, object] | None = None,
525522
) -> None: ...
526-
527-
if sys.version_info < (3, 13):
528-
def warn(
529-
msg: object,
530-
*args: object,
531-
exc_info: _ExcInfoType = None,
532-
stack_info: bool = False,
533-
stacklevel: int = 1,
534-
extra: Mapping[str, object] | None = None,
535-
) -> None: ...
536-
523+
@deprecated("Deprecated; use warning() instead.")
524+
def warn(
525+
msg: object,
526+
*args: object,
527+
exc_info: _ExcInfoType = None,
528+
stack_info: bool = False,
529+
stacklevel: int = 1,
530+
extra: Mapping[str, object] | None = None,
531+
) -> None: ...
537532
def error(
538533
msg: object,
539534
*args: object,

0 commit comments

Comments
 (0)