Skip to content

Commit 4b360ca

Browse files
authored
TypedDict: fix keys, values, items return value (#3529)
Fixes #3473 Co-authored-by: hauntsaninja <>
1 parent 6f159d9 commit 4b360ca

File tree

3 files changed

+11
-0
lines changed

3 files changed

+11
-0
lines changed

stdlib/3/typing.pyi

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -651,6 +651,9 @@ class _TypedDict(Mapping[str, object], metaclass=ABCMeta):
651651
def pop(self, k: NoReturn, default: _T = ...) -> object: ...
652652
def update(self: _T, __m: _T) -> None: ...
653653
def __delitem__(self, k: NoReturn) -> None: ...
654+
def items(self) -> ItemsView[str, object]: ...
655+
def keys(self) -> KeysView[str]: ...
656+
def values(self) -> ValuesView[object]: ...
654657

655658
def NewType(name: str, tp: Type[_T]) -> Type[_T]: ...
656659

third_party/2and3/mypy_extensions.pyi

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,10 @@ class _TypedDict(Mapping[str, object], metaclass=abc.ABCMeta):
2222
def viewitems(self) -> ItemsView[str, object]: ...
2323
def viewkeys(self) -> KeysView[str]: ...
2424
def viewvalues(self) -> ValuesView[object]: ...
25+
else:
26+
def items(self) -> ItemsView[str, object]: ...
27+
def keys(self) -> KeysView[str]: ...
28+
def values(self) -> ValuesView[object]: ...
2529
def __delitem__(self, k: NoReturn) -> None: ...
2630

2731
def TypedDict(typename: str, fields: Dict[str, Type[_T]], total: bool = ...) -> Type[Dict[str, Any]]: ...

third_party/2and3/typing_extensions.pyi

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,10 @@ class _TypedDict(Mapping[str, object], metaclass=abc.ABCMeta):
4242
def viewitems(self) -> ItemsView[str, object]: ...
4343
def viewkeys(self) -> KeysView[str]: ...
4444
def viewvalues(self) -> ValuesView[object]: ...
45+
else:
46+
def items(self) -> ItemsView[str, object]: ...
47+
def keys(self) -> KeysView[str]: ...
48+
def values(self) -> ValuesView[object]: ...
4549
def __delitem__(self, k: NoReturn) -> None: ...
4650

4751
# TypedDict is a (non-subscriptable) special form.

0 commit comments

Comments
 (0)