Skip to content

test-with-buildbots is not triggering buildbots #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tiran opened this issue Apr 23, 2021 · 13 comments
Open

test-with-buildbots is not triggering buildbots #103

tiran opened this issue Apr 23, 2021 · 13 comments

Comments

@tiran
Copy link
Member

tiran commented Apr 23, 2021

On PR python/cpython#25553 the test-with-buildbots label doesn't trigger buildbot testing properly. In the first attempt no buildbot was triggered. I tried again 15 minutes later. The second time only buildbot/s390x Debian PR got started.

CC: @pablogsal @vstinner

@pablogsal
Copy link
Member

On PR python/cpython#25553 the test-with-buildbots label doesn't trigger buildbot testing properly. In the first attempt no buildbot was triggered. I tried again 15 minutes later. The second time only buildbot/s390x Debian PR got started.

That's because the builbots are busy. They only start reporting when they receive your request. You can see the queried requests here:

https://buildbot.python.org/all/#/pendingbuildrequests

@tiran
Copy link
Member Author

tiran commented Apr 23, 2021

Thanks @pablogsal, I didn't know that. Is there a simple way to improve reporting? Or should I create a PR to include the link into the Bedevere reply?

@pablogsal
Copy link
Member

For example, for your PR python/cpython#25553 :

this buildbot has these builds:

https://buildbot.python.org/all/#/builders/500

and here is your pending request:

https://buildbot.python.org/all/#/buildrequests/199658

@pablogsal
Copy link
Member

Thanks @pablogsal, I didn't know that. Is there a simple way to improve reporting? Or should I create a PR to include the link into the Bedevere reply?

We should investigate if is possible to report a "pending" check as soon as they trigger

@pablogsal
Copy link
Member

In the buildbot docs, seems that the only generators that they have are:

http://docs.buildbot.net/latest/manual/configuration/report_generators/index.html

and the one we use only reports starts/ends:

http://docs.buildbot.net/latest/manual/configuration/report_generators/build_start_end.html#reportgen-buildstartendstatusgenerator

We could either improve the error message or/and try to make our custom generator to report as soon as we receive the request.

@pablogsal
Copy link
Member

Or should I create a PR to include the link into the Bedevere reply?

Do you mind making a PR to include the link? The code is here:

https://github.com/python/buildmaster-config/blob/f0b45256606d6173924c5b35e718944eaf0e2795/master/custom/pr_testing.py#L16

@tiran
Copy link
Member Author

tiran commented Apr 23, 2021

I'm bit busy right now. Can you assign this ticket to me, please? I'll take a look later or early next week. I don't have permission to self-assign on this tracker.

@pablogsal
Copy link
Member

pablogsal commented Apr 23, 2021

I don't have permission to self-assign on this tracker.

Me neither (have permissions over the tracker), but don't worry, given that everyone is using the label these two weeks quite a lot I will try to do it today so there is no more confusion regarding this.

Thanks for raising this @tiran

@pablogsal
Copy link
Member

I think this may improve the situation: python/buildmaster-config#242

@tiran
Copy link
Member Author

tiran commented Apr 23, 2021

I think this may improve the situation: python/buildmaster-config#242

Fantastic!

I noticed that cancelled jobs are marked as failed.

@pablogsal
Copy link
Member

Yeah, I scheduled a new run for your PR

@pablogsal
Copy link
Member

pablogsal commented Apr 23, 2021

You need to still manually inspect failures because there are still known problems :( :

https://buildbot.python.org/all/#/release_status

@vstinner
Copy link
Member

This psf-infra-meta is a broad project, I suggest to use the more specific list https://mail.python.org/mailman3/lists/python-buildbots.python.org/ (or https://github.com/python/core-workflow/issues ) to report buildbot issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants