diff --git a/mypy/semanal.py b/mypy/semanal.py index b14e3dd9076e..6e7fad1f7adf 100644 --- a/mypy/semanal.py +++ b/mypy/semanal.py @@ -3315,7 +3315,7 @@ def check_no_global(self, n: str, ctx: Context, elif prev_is_overloaded: self.fail("Definition of '{}' missing 'overload'".format(n), ctx) else: - self.name_already_defined(n, ctx) + self.name_already_defined(n, ctx, self.globals[n]) def name_not_defined(self, name: str, ctx: Context) -> None: message = "Name '{}' is not defined".format(name) @@ -3324,8 +3324,16 @@ def name_not_defined(self, name: str, ctx: Context) -> None: message += ' {}'.format(extra) self.fail(message, ctx) - def name_already_defined(self, name: str, ctx: Context) -> None: - self.fail("Name '{}' already defined".format(name), ctx) + def name_already_defined(self, name: str, ctx: Context, + original_ctx: Optional[SymbolTableNode] = None) -> None: + if original_ctx: + if original_ctx.node and original_ctx.node.get_line() != -1: + extra_msg = ' on line {}'.format(original_ctx.node.get_line()) + else: + extra_msg = ' (possibly by an import)' + else: + extra_msg = '' + self.fail("Name '{}' already defined{}".format(name, extra_msg), ctx) def fail(self, msg: str, ctx: Context, serious: bool = False, *, blocker: bool = False) -> None: diff --git a/test-data/unit/check-classes.test b/test-data/unit/check-classes.test index a257fa0375f0..3e9ab9924809 100644 --- a/test-data/unit/check-classes.test +++ b/test-data/unit/check-classes.test @@ -714,7 +714,7 @@ A() class A: pass class A: pass [out] -main:4: error: Name 'A' already defined +main:4: error: Name 'A' already defined on line 3 [case testDocstringInClass] import typing diff --git a/test-data/unit/check-functions.test b/test-data/unit/check-functions.test index 8ac35e052659..fb76185569d5 100644 --- a/test-data/unit/check-functions.test +++ b/test-data/unit/check-functions.test @@ -1212,7 +1212,7 @@ from typing import Any x = None # type: Any if x: def f(): pass -def f(): pass # E: Name 'f' already defined +def f(): pass # E: Name 'f' already defined on line 4 [case testIncompatibleConditionalFunctionDefinition] from typing import Any @@ -1835,7 +1835,7 @@ f = g # E: Incompatible types in assignment (expression has type Callable[[Any, [case testRedefineFunction2] def f() -> None: pass -def f() -> None: pass # E: Name 'f' already defined +def f() -> None: pass # E: Name 'f' already defined on line 1 -- Special cases diff --git a/test-data/unit/check-overloading.test b/test-data/unit/check-overloading.test index 69289fae18c1..f3e5b993a325 100644 --- a/test-data/unit/check-overloading.test +++ b/test-data/unit/check-overloading.test @@ -1106,7 +1106,7 @@ def f(a: int) -> None: pass def f(a: str) -> None: pass [out] tmp/foo.pyi:2: error: Single overload definition, multiple required -tmp/foo.pyi:5: error: Name 'f' already defined +tmp/foo.pyi:5: error: Name 'f' already defined on line 2 [case testOverloadTuple] from foo import * diff --git a/test-data/unit/check-semanal-error.test b/test-data/unit/check-semanal-error.test index 0a078290a1a7..1869bbe8e366 100644 --- a/test-data/unit/check-semanal-error.test +++ b/test-data/unit/check-semanal-error.test @@ -79,3 +79,19 @@ yield # E: 'yield' outside function [case testYieldFromOutsideFunction] x = 1 yield from x # E: 'yield from' outside function + +[case testImportFuncDup] +import m +def m() -> None: ... # ok + +[file m.py] +[out] + +[case testIgnoredImportDup] +import m # type: ignore +from m import f # type: ignore +def m() -> None: ... # ok +def f() -> None: ... # ok + +[out] + diff --git a/test-data/unit/semanal-errors.test b/test-data/unit/semanal-errors.test index 99584e77a977..9c7713d9cdb7 100644 --- a/test-data/unit/semanal-errors.test +++ b/test-data/unit/semanal-errors.test @@ -165,7 +165,7 @@ import typing class A: pass class A: pass [out] -main:3: error: Name 'A' already defined +main:3: error: Name 'A' already defined on line 2 [case testMultipleMixedDefinitions] import typing @@ -173,8 +173,8 @@ x = 1 def x(): pass class x: pass [out] -main:3: error: Name 'x' already defined -main:4: error: Name 'x' already defined +main:3: error: Name 'x' already defined on line 2 +main:4: error: Name 'x' already defined on line 2 [case testNameNotImported] import typing @@ -1037,13 +1037,13 @@ t = 1 # E: Invalid assignment target [case testRedefineTypevar2] from typing import TypeVar t = TypeVar('t') -def t(): pass # E: Name 't' already defined +def t(): pass # E: Name 't' already defined on line 2 [out] [case testRedefineTypevar3] from typing import TypeVar t = TypeVar('t') -class t: pass # E: Name 't' already defined +class t: pass # E: Name 't' already defined on line 2 [out] [case testRedefineTypevar4] @@ -1330,3 +1330,74 @@ a = ('spam', 'spam', 'eggs', 'spam') # type: Tuple[str] [out] main:3: error: Name 'a' already defined main:4: error: Name 'a' already defined + +[case testDuplicateDefFromImport] +from m import A +class A: # E: Name 'A' already defined (possibly by an import) + pass +[file m.py] +class A: + pass +[out] + +[case testDuplicateDefDec] +from typing import Any +def dec(x: Any) -> Any: + return x +@dec +def f() -> None: + pass +@dec # E: Name 'f' already defined +def f() -> None: + pass +[out] + +[case testDuplicateDefOverload] +from typing import overload +if 1: + @overload + def f(x: int) -> None: + pass + @overload + def f(x: str) -> None: + pass + def f(x: Any) -> None: + pass +else: + def f(x: str) -> None: # E: Name 'f' already defined on line 3 + pass +[out] + +[case testDuplicateDefNT] +from typing import NamedTuple +N = NamedTuple('N', [('a', int), + ('b', str)]) + +class N: # E: Name 'N' already defined on line 2 + pass +[out] + +[case testDuplicateDefTypedDict] +from mypy_extensions import TypedDict +Point = TypedDict('Point', {'x': int, 'y': int}) + +class Point: # E: Name 'Point' already defined on line 2 + pass +[builtins fixtures/dict.pyi] + +[out] + +[case testTypeVarClassDup] +from typing import TypeVar +T = TypeVar('T') +class T: ... # E: Name 'T' already defined on line 2 + +[out] + +[case testAliasDup] +from typing import List +A = List[int] +class A: ... # E: Name 'A' already defined on line 2 + +[builtins fixtures/list.pyi] +[out]