From 3d5bff9492de550233cd6a1d3c11a247a805685e Mon Sep 17 00:00:00 2001 From: Cibin Mathew <10793628+cibinmathew@users.noreply.github.com> Date: Mon, 21 Mar 2022 10:11:24 +0530 Subject: [PATCH 1/2] Fix: Empty reveal locals ouput Fixes https://github.com/python/mypy/issues/12388 --- mypy/messages.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/mypy/messages.py b/mypy/messages.py index bb6977190105..be48332e1784 100644 --- a/mypy/messages.py +++ b/mypy/messages.py @@ -1171,9 +1171,12 @@ def reveal_locals(self, type_map: Dict[str, Optional[Type]], context: Context) - # To ensure that the output is predictable on Python < 3.6, # use an ordered dictionary sorted by variable name sorted_locals = OrderedDict(sorted(type_map.items(), key=lambda t: t[0])) - self.note("Revealed local types are:", context) - for line in [' {}: {}'.format(k, v) for k, v in sorted_locals.items()]: - self.note(line, context) + if sorted_locals: + self.note("Revealed local types are:", context) + for line in [' {}: {}'.format(k, v) for k, v in sorted_locals.items()]: + self.note(line, context) + else: + self.note("There are no locals to reveal", context) def unsupported_type_type(self, item: Type, context: Context) -> None: self.fail('Cannot instantiate type "Type[{}]"'.format(format_type_bare(item)), context) From 2afd03107ef69bf9b2eca7101043a7bd5e8c69f1 Mon Sep 17 00:00:00 2001 From: Cibin Mathew Date: Mon, 21 Mar 2022 23:04:18 +0530 Subject: [PATCH 2/2] Fix: Empty reveal locals ouput Fixes https://github.com/python/mypy/issues/12388 --- mypy/messages.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mypy/messages.py b/mypy/messages.py index be48332e1784..f067e7e06bd4 100644 --- a/mypy/messages.py +++ b/mypy/messages.py @@ -1173,8 +1173,8 @@ def reveal_locals(self, type_map: Dict[str, Optional[Type]], context: Context) - sorted_locals = OrderedDict(sorted(type_map.items(), key=lambda t: t[0])) if sorted_locals: self.note("Revealed local types are:", context) - for line in [' {}: {}'.format(k, v) for k, v in sorted_locals.items()]: - self.note(line, context) + for k, v in sorted_locals.items(): + self.note(' {}: {}'.format(k, v), context) else: self.note("There are no locals to reveal", context)