-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Add "<function> defined here" notes to more errors #4773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I find this confusing when using editor linters like Ale, without more info included other than "defined here". There will be a break point to the left of the I came across this issue when googling what on earth this linter note even means. |
The comment above seems pretty reasonable. Please fix, Thanks. |
Agreed with the comment from @tommyjcarpenter ! |
I completely agree. It's frustrating that the linter highlights the function definition rather than the incorrect calls to that function. On top of that, the user also gets a vague message like "function foo defined here," which doesn't provide any useful context. It would be much more helpful if it specified something like "defined here, but called incorrectly elsewhere." This lack of clarity led me to search for more information online to understand what the linter was trying to convey. |
Came here to find out why mypy is telling me that my function is defined 'here'. Odd message. Now I understand what it means, but the message shouldn't need me to search to find out what it means. |
How can this be disabled? It's not really helpful and if anything it's extremely annoying in any IDE that was developed in the last century. |
mypy produces a nice " defined here" note when calling a function with unexpected kwargs, but in no other situation. We should consider adding the note to every function call typechecking failure.
Probably should wait until #4772 is fixed though?
The text was updated successfully, but these errors were encountered: