Add "<function> defined here" notes to more errors

[msullivan]

mypy produces a nice " defined here" note when calling a function with unexpected kwargs, but in no other situation. We should consider adding the note to every function call typechecking failure.

Probably should wait until #4772 is fixed though?

[tommyjcarpenter]

I find this confusing when using editor linters like Ale, without more info included other than "defined here". There will be a break point to the left of the def foo line and it just says "function foo defined here", like, "ok, so??" it doesn't give any additional context of why it is telling me this or what the problem is. Nicer would be "defined here but a caller is calling incorrectly" or something along those lines.

I came across this issue when googling what on earth this linter note even means.

[Sesota]

The comment above seems pretty reasonable. Please fix, Thanks.

[MatthieuToulemont]

Agreed with the comment from @tommyjcarpenter !

[udiNur]

I find this confusing when using editor linters like Ale, without more info included other than "defined here". There will be a break point to the left of the def foo line and it just says "function foo defined here", like, "ok, so??" it doesn't give any additional context of why it is telling me this or what the problem is. Nicer would be "defined here but a caller is calling incorrectly" or something along those lines.

I came across this issue when googling what on earth this linter note even means.

I completely agree. It's frustrating that the linter highlights the function definition rather than the incorrect calls to that function. On top of that, the user also gets a vague message like "function foo defined here," which doesn't provide any useful context. It would be much more helpful if it specified something like "defined here, but called incorrectly elsewhere." This lack of clarity led me to search for more information online to understand what the linter was trying to convey.

[tsheaff]

This even confuses an LLM. This is Cursor 3.5 Sonnet's "Fix in Composer" and the LLM is like "doesn't seem like an error to me, it's defined right here" which is, to be fair to Claude, exactly what I thought when I read it the first time too 😆

[BackSeat]

Came here to find out why mypy is telling me that my function is defined 'here'. Odd message. Now I understand what it means, but the message shouldn't need me to search to find out what it means.

[nonamethanks]

How can this be disabled? It's not really helpful and if anything it's extremely annoying in any IDE that was developed in the last century.