Skip to content

TYP: fix NDArray[integer] inplace operator mypy issue #29092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2025
Merged

TYP: fix NDArray[integer] inplace operator mypy issue #29092

merged 2 commits into from
May 30, 2025
+33 −131

Conversation

jorenham
Copy link
Member

@jorenham jorenham commented May 30, 2025 •
edited
Loading

fixes python/mypy#19171

Note that this does not affect the return type; this just broadens the input (self) type.

The unsignedinteger overloads could be removed because _ArrayLikeInt_co already covers the array-likes of integer or bool.

@jorenham jorenham added 09 - Backport-Candidate PRs tagged should be backported 41 - Static typing labels May 30, 2025
@jorenham jorenham added this to the 2.3.0 release milestone May 30, 2025
@jorenham jorenham mentioned this pull request May 30, 2025
Open
@charris charris merged commit e699298 into numpy:main May 30, 2025
76 checks passed
@charris
Copy link
Member

charris commented May 30, 2025

Thanks Joren.

@jorenham jorenham deleted the typing/mypy-19171 branch May 30, 2025 21:47
@charris charris mentioned this pull request May 31, 2025
Merged
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label May 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
41 - Static typing
Projects
None yet
Milestone
2.3.0 release
Development

Successfully merging this pull request may close these issues.

"Invalid self argument" for numpy's iadd
2 participants
@jorenham @charris