Skip to content

pre-commit not installed via test-requirements.txt #17902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JukkaL opened this issue Oct 9, 2024 · 4 comments · Fixed by #17911
Closed

pre-commit not installed via test-requirements.txt #17902

JukkaL opened this issue Oct 9, 2024 · 4 comments · Fixed by #17911
Labels
good-first-issue topic-developer Issues relevant to mypy developers

Comments

@JukkaL
Copy link
Collaborator

JukkaL commented Oct 9, 2024

When I run python runtests.py in a freshly created venv where I've installed test-requirements.txt, I get this error:

FileNotFoundError: [Errno 2] No such file or directory: 'pre-commit'

pip install pre-commit fixes this, but I think we should install it automatically in test-requirements.txt.

@JukkaL JukkaL added topic-developer Issues relevant to mypy developers good-first-issue labels Oct 9, 2024
@gaurovgiri
Copy link
Contributor

Hello @JukkaL, I would like to work on this issue. Could you assign this to me?

@JelleZijlstra
Copy link
Member

Feel free to work on this issue and send in a PR!

@Donald-0017
Copy link

Hi, JukkaL,I am very interested in thsi issue,would you like to assign it to me ?Thank you. @JukkaL

@gaurovgiri
Copy link
Contributor

@JukkaL and @JelleZijlstra, I have created a PR. Can someone review it and help me resolve the failed task in github actions. Your help would be much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue topic-developer Issues relevant to mypy developers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants