Skip to content

"Make mypy more positive #7368" breaks CI/CD workflow #14349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snowyurik opened this issue Dec 26, 2022 · 3 comments
Closed

"Make mypy more positive #7368" breaks CI/CD workflow #14349

snowyurik opened this issue Dec 26, 2022 · 3 comments
Labels
bug mypy got something wrong

Comments

@snowyurik
Copy link

Bug Report
Unwanted output on success. However I need to be able to capture both error message and any script output on failure.

To Reproduce

  • create valid python script
  • run mypy script.py

Expected Behavior
return empty string and status 0

Actual Behavior
returned "Positive" string "Success: no issues found in 1 source file"

Your Environment

  • Mypy version used: 0.982

Suggestion
You can use something like 'mypy --cicd script.py' to switch between "positive" and useful mode.

@snowyurik snowyurik added the bug mypy got something wrong label Dec 26, 2022
@JelleZijlstra
Copy link
Member

Why can't you rely on the exit status 0 for determining whether mypy was successful? What is the concrete problem here?

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Dec 27, 2022

The concrete problem is that OP is rather rude. If OP read the docs they'd know there's a flag to remove the summary message.

@hauntsaninja hauntsaninja closed this as not planned Won't fix, can't repro, duplicate, stale Dec 27, 2022
@snowyurik
Copy link
Author

snowyurik commented Jan 12, 2023

So --no-error-summary is quiet mode? Ok... thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug mypy got something wrong
Projects
None yet
Development

No branches or pull requests

3 participants