Skip to content

When black fails in CI, tell how to fix it #13606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JukkaL opened this issue Sep 4, 2022 · 3 comments
Closed

When black fails in CI, tell how to fix it #13606

JukkaL opened this issue Sep 4, 2022 · 3 comments
Labels
feature topic-developer Issues relevant to mypy developers

Comments

@JukkaL
Copy link
Collaborator

JukkaL commented Sep 4, 2022

If Black fails in CI, it would be nice to show prominently the exact command needed to fix the issue (possibly just black .). I guess isort could be similar. This could help new contributors who haven't used Black before.
@JukkaL JukkaL added feature topic-developer Issues relevant to mypy developers labels Sep 4, 2022
@AlexWaygood
Copy link
Member

AlexWaygood commented Sep 4, 2022 •
edited
Loading

If we adopted pre-commit.ci (#13281), then black and isort would be auto-applied to PRs that violate the coding style, so contributors wouldn't need to manually fix their PRs.

@sobolevn
Copy link
Member

sobolevn commented Sep 5, 2022

It would be very helpful!

@hauntsaninja
Copy link
Collaborator

Closing since #13281 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature topic-developer Issues relevant to mypy developers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JukkaL @sobolevn @hauntsaninja @AlexWaygood