Skip to content

Handle interaction of -i and -s #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gvanrossum opened this issue Apr 8, 2016 · 2 comments
Closed

Handle interaction of -i and -s #1351

gvanrossum opened this issue Apr 8, 2016 · 2 comments
Assignees

Comments

@gvanrossum
Copy link
Member

When using --incremental mode (-i) with -s (--silent-imports) the cache should technically be invalidated when a different set of files is passed, since imports that are "silenced" by this flag are stored as objects of type Any in the importing module's namespace.

We need this to work seamlessly, either by emptying the cache whenever the set of files changes, or by recording the silenced dependencies in the cache metadata, or by some other approach.

@gvanrossum gvanrossum added this to the Undetermined priority milestone Apr 8, 2016
@ddfisher
Copy link
Collaborator

ddfisher commented Apr 8, 2016

Talked in person. It looks like adding some indication in the cache file or metadata that the file was excluded due to -s could be a fruitful approach. We'd need to check if files have explicit dependencies on their silent imports or not (and add that if they don't).

@gvanrossum gvanrossum modified the milestones: 0.3.2, Undetermined priority Apr 11, 2016
@gvanrossum gvanrossum self-assigned this Apr 11, 2016
@gvanrossum
Copy link
Member Author

Fixed by d84bdea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants