Skip to content

Commit ffcedb0

Browse files
author
Guido van Rossum
committed
Be aware of StarExpr in tuple when checking string conversions
1 parent 0bb2d16 commit ffcedb0

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

mypy/checkstrformat.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
Type, AnyType, TupleType, Instance, UnionType
99
)
1010
from mypy.nodes import (
11-
StrExpr, BytesExpr, UnicodeExpr, TupleExpr, DictExpr, Context, Expression
11+
StrExpr, BytesExpr, UnicodeExpr, TupleExpr, DictExpr, Context, Expression, StarExpr
1212
)
1313
if False:
1414
# break import cycle only needed for mypy
@@ -140,7 +140,8 @@ def check_simple_str_interpolation(self, specifiers: List[ConversionSpecifier],
140140
check_type(rhs_type.items[0])
141141
else:
142142
check_node(replacements)
143-
elif isinstance(replacements, TupleExpr):
143+
elif (isinstance(replacements, TupleExpr)
144+
and not any(isinstance(item, StarExpr) for item in replacements.items)):
144145
for checks, rep_node in zip(checkers, replacements.items):
145146
check_node, check_type = checks
146147
check_node(rep_node)

0 commit comments

Comments
 (0)