Skip to content

Commit aaaf4c4

Browse files
committed
Address code review feedback
1 parent af4e8fd commit aaaf4c4

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

mypy/semanal.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -986,16 +986,16 @@ def analyze_overloaded_func_def(self, defn: OverloadedFuncDef) -> None:
986986
# We know this is an overload def. Infer properties and perform some checks.
987987
self.process_final_in_overload(defn)
988988
self.process_static_or_class_method_in_overload(defn)
989-
if defn.impl:
990-
self.process_overload_impl(defn)
989+
self.process_overload_impl(defn)
991990

992991
def process_overload_impl(self, defn: OverloadedFuncDef) -> None:
993992
"""Set flags for an overload implementation.
994993
995994
Currently, this checks for a trivial body in protocols classes,
996995
where it makes the method implicitly abstract.
997996
"""
998-
assert defn.impl is not None
997+
if defn.impl is None:
998+
return
999999
impl = defn.impl if isinstance(defn.impl, FuncDef) else defn.impl.func
10001000
if is_trivial_body(impl.body) and self.is_class_scope() and not self.is_stub_file:
10011001
assert self.type is not None

0 commit comments

Comments
 (0)