Skip to content

Commit 97e7f3e

Browse files
authored
Don't run flake8 twice in CI (#15129)
1 parent 00f3913 commit 97e7f3e

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

.github/workflows/test.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,9 @@ jobs:
9393
arch: x64
9494
os: windows-latest
9595
toxenv: type
96+
# We also run these checks with pre-commit in CI,
97+
# but it's useful to run them with tox too,
98+
# to ensure the tox env works as expected
9699
- name: Formatting with Black + isort and code style with flake8
97100
python: '3.7'
98101
arch: x64

.pre-commit-config.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,3 +14,7 @@ repos:
1414
additional_dependencies:
1515
- flake8-bugbear==22.12.6 # must match test-requirements.txt
1616
- flake8-noqa==1.3.0 # must match test-requirements.txt
17+
18+
ci:
19+
# We run flake8 as part of our GitHub Actions suite in CI
20+
skip: [flake8]

0 commit comments

Comments
 (0)