Skip to content

Commit 9611e2d

Browse files
authored
Fix sidebar logo not loading in HTML docs (#12939)
The mypy logo wasn't loading on https://mypy.readthedocs.io/ because it's referenced via an http:// (not https) URL. The logo's URL is http://mypy-lang.org/static/mypy_light.svg; that server is not accessible via https, so I've moved mypy_light.svg into docs/source and referenced it from there. The project README also referenced the logo via the same URL, so for consistency, the README now points at the same logo file in docs/source. (Although the README's logo did load because GitHub proxies external resources referenced in markdown files).
1 parent 8153e47 commit 9611e2d

File tree

3 files changed

+101
-2
lines changed

3 files changed

+101
-2
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<img src="http://mypy-lang.org/static/mypy_light.svg" alt="mypy logo" width="300px"/>
1+
<img src="docs/source/mypy_light.svg" alt="mypy logo" width="300px"/>
22

33
Mypy: Static Typing for Python
44
=======================================

docs/source/conf.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@
122122

123123
# The name of an image file (relative to this directory) to place at the top
124124
# of the sidebar.
125-
html_logo = "http://mypy-lang.org/static/mypy_light.svg"
125+
html_logo = "mypy_light.svg"
126126

127127
# The name of an image file (within the static path) to use as favicon of the
128128
# docs. This file should be a Windows icon file (.ico) being 16x16 or 32x32

docs/source/mypy_light.svg

Lines changed: 99 additions & 0 deletions
Loading

0 commit comments

Comments
 (0)