more tests

Author: JelleZijlstra

mypy/newsemanal/semanal_pass1.py

@@ -90,6 +90,8 @@ def visit_import(self, node: Import) -> None:
 
     def visit_if_stmt(self, s: IfStmt) -> None:
         infer_reachability_of_if_statement(s, self.options)
+        for expr in s.expr:
+            expr.accept(self)
         for node in s.body:
             node.accept(self)
         if s.else_body:

mypy/semanal_pass1.py

@@ -174,6 +174,9 @@ def visit_func_def(self, func: FuncDef, decorated: bool = False) -> None:
         if sem.type is not None:
             # Don't process methods during pass 1.
             return
+        for arg in func.arguments:
+            if arg.initializer:
+                arg.initializer.accept(self)
         func.is_conditional = sem.block_depth[-1] > 0
         func._fullname = sem.qualified_name(func.name())
         at_module = sem.is_module_scope() and not decorated
@@ -309,6 +312,7 @@ def visit_import_all(self, node: ImportAll) -> None:
 
     def visit_while_stmt(self, s: WhileStmt) -> None:
         if self.sem.is_module_scope():
+            s.expr.accept(self)
             s.body.accept(self)
             if s.else_body:
                 s.else_body.accept(self)

test-data/unit/check-38.test

@@ -110,3 +110,48 @@ def g(x: int): ...
 [case testWalrus]
 if (a := 2):
     reveal_type(a)  # E: Revealed type is 'builtins.int'
+
+while (b := "x"):
+    reveal_type(b)  # E: Revealed type is 'builtins.str'
+
+def f(x: int = (c := 4)) -> None:
+    if (a := 2):
+        reveal_type(a)  # E: Revealed type is 'builtins.int'
+
+    while (b := "x"):
+        reveal_type(b)  # E: Revealed type is 'builtins.str'
+
+    x = (y := 1) + (z := 2)
+    reveal_type(x)  # E: Revealed type is 'builtins.int'
+    reveal_type(y)  # E: Revealed type is 'builtins.int'
+    reveal_type(z)  # E: Revealed type is 'builtins.int'
+
+    l = [y2 := 1, y2 + 2, y2 + 3]
+    reveal_type(y2)  # E: Revealed type is 'builtins.int'
+    reveal_type(l)  # E: Revealed type is 'builtins.list[builtins.int*]'
+
+    filtered_data = [y3 for x in l if (y3 := a) is not None]
+    reveal_type(filtered_data)  # E: Revealed type is 'builtins.list[builtins.int*]'
+    # TODO this should be valid: https://www.python.org/dev/peps/pep-0572/#scope-of-the-target
+    y3  # E: Name 'y3' is not defined
+
+    # https://www.python.org/dev/peps/pep-0572/#exceptional-cases
+    (y4 := 3)
+    reveal_type(y4)  # E: Revealed type is 'builtins.int'
+
+    y5 = (y6 := 3)
+    reveal_type(y5)  # E: Revealed type is 'builtins.int'
+    reveal_type(y6)  # E: Revealed type is 'builtins.int'
+
+    f(x=(y7 := 3))
+    reveal_type(y7)  # E: Revealed type is 'builtins.int'
+
+    reveal_type((lambda: (y8 := 3) and y8)())  # E: Revealed type is 'builtins.int'
+
+    y7 = 1.0  # E: Incompatible types in assignment (expression has type "float", variable has type "int")
+    if y7 := "x":  # E: Incompatible types in assignment (expression has type "str", variable has type "int")
+        pass
+
+reveal_type(c)  # E: Revealed type is 'builtins.int'
+
+[builtins fixtures/f_string.pyi]