Skip to content

Commit 56bb4ba

Browse files
committed
runtests: start eval-test first because it's the long pole
Running with 8-way concurrency on my desktop, and after the optimizations made in the last few commits, the whole run finishes when this one test does, long after all other tests have completed. Clearly it ought to be broken up; first and easier, do the best we can by putting it right at the head of the queue.
1 parent e63e755 commit 56bb4ba

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

runtests.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,11 +200,16 @@ def add_myunit(driver: Driver) -> None:
200200
elif mod == 'mypy.test.testpythoneval':
201201
# Run Python evaluation integration tests separetely since they are much slower
202202
# than proper unit tests.
203-
driver.add_python_mod('eval-test %s' % mod, 'mypy.myunit', '-m', mod, *driver.arglist)
203+
pass
204204
else:
205205
driver.add_python_mod('unit-test %s' % mod, 'mypy.myunit', '-m', mod, *driver.arglist)
206206

207207

208+
def add_pythoneval(driver: Driver) -> None:
209+
driver.add_python_mod('eval-test', 'mypy.myunit',
210+
'-m', 'mypy.test.testpythoneval', *driver.arglist)
211+
212+
208213
def add_stubs(driver: Driver) -> None:
209214
# We only test each module in the one version mypy prefers to find.
210215
# TODO: test stubs for other versions, especially Python 2 stubs.
@@ -349,6 +354,7 @@ def main() -> None:
349354
driver.prepend_path('PYTHONPATH', [driver.cwd])
350355
driver.prepend_path('PYTHONPATH', [join(driver.cwd, 'lib-typing', v) for v in driver.versions])
351356

357+
add_pythoneval(driver)
352358
add_basic(driver)
353359
add_selftypecheck(driver)
354360
add_myunit(driver)

0 commit comments

Comments
 (0)