[Refactoring] Remove TypeInfo.alt_fullname (#3165)

Author: elazarg

mypy/nodes.py

@@ -9,7 +9,7 @@
 
 import mypy.strconv
 from mypy.visitor import NodeVisitor, StatementVisitor, ExpressionVisitor
-from mypy.util import short_type, IdMapper
+from mypy.util import short_type
 
 
 class Context:
@@ -1988,9 +1988,6 @@ class is generic then it will be a type constructor of higher kind.
     # Is this a newtype type?
     is_newtype = False
 
-    # Alternative to fullname() for 'anonymous' classes.
-    alt_fullname = None  # type: Optional[str]
-
     FLAGS = [
         'is_abstract', 'is_enum', 'fallback_to_any', 'is_named_tuple',
         'is_newtype'
@@ -2171,8 +2168,7 @@ def serialize(self) -> JsonDict:
         data = {'.class': 'TypeInfo',
                 'module_name': self.module_name,
                 'fullname': self.fullname(),
-                'alt_fullname': self.alt_fullname,
-                'names': self.names.serialize(self.alt_fullname or self.fullname()),
+                'names': self.names.serialize(self.fullname()),
                 'defn': self.defn.serialize(),
                 'abstract_attributes': self.abstract_attributes,
                 'type_vars': self.type_vars,
@@ -2194,7 +2190,6 @@ def deserialize(cls, data: JsonDict) -> 'TypeInfo':
         module_name = data['module_name']
         ti = TypeInfo(names, defn, module_name)
         ti._fullname = data['fullname']
-        ti.alt_fullname = data['alt_fullname']
         # TODO: Is there a reason to reconstruct ti.subtypes?
         ti.abstract_attributes = data['abstract_attributes']
         ti.type_vars = data['type_vars']
@@ -2303,14 +2298,7 @@ def serialize(self, prefix: str, name: str) -> JsonDict:
         else:
             if self.node is not None:
                 if prefix is not None:
-                    # Check whether this is an alias for another object.
-                    # If the object's canonical full name differs from
-                    # the full name computed from prefix and name,
-                    # it's an alias, and we serialize it as a cross ref.
-                    if isinstance(self.node, TypeInfo):
-                        fullname = self.node.alt_fullname or self.node.fullname()
-                    else:
-                        fullname = self.node.fullname()
+                    fullname = self.node.fullname()
                     if (fullname is not None and '.' in fullname and
                             fullname != prefix + '.' + name):
                         data['cross_ref'] = fullname

mypy/server/astdiff.py

@@ -81,7 +81,6 @@ def is_similar_node_shallow(n: SymbolTableNode, m: SymbolTableNode) -> bool:
                 nn.fallback_to_any == mn.fallback_to_any and
                 nn.is_named_tuple == mn.is_named_tuple and
                 nn.is_newtype == mn.is_newtype and
-                nn.alt_fullname == mn.alt_fullname and
                 is_same_mro(nn.mro, mn.mro))
     if isinstance(n.node, Var) and isinstance(m.node, Var):
         return is_identical_type(n.node.type, m.node.type)

mypy/types.py

@@ -390,7 +390,7 @@ def accept(self, visitor: 'TypeVisitor[T]') -> T:
 
     def serialize(self) -> Union[JsonDict, str]:
         assert self.type is not None
-        type_ref = self.type.alt_fullname or self.type.fullname()
+        type_ref = self.type.fullname()
         if not self.args:
             return type_ref
         data = {'.class': 'Instance',