Skip to content

Commit e76da57

Browse files
committed
Merge branch 'nonocov' into 'master'
Remove use of `nocov` environments and factors See merge request python-devs/importlib_resources!78
2 parents b3a3481 + 3ea5fd5 commit e76da57

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

.gitlab-ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ qa:
1111

1212
tests:
1313
script:
14-
- tox -e py27-nocov,py34-nocov,py35-nocov,py36-nocov
14+
- tox -e py27,py34,py35,py36,py37,py38
1515

1616
coverage:
1717
script:

importlib_resources/_py2.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ def contents(package):
219219
relpath = package_directory.relative_to(archive_path)
220220
with ZipFile(archive_path) as zf:
221221
toc = zf.namelist()
222-
subdirs_seen = set() # type: Set
222+
subdirs_seen = set()
223223
subdirs_returned = []
224224
for filename in toc:
225225
path = Path(filename)

tox.ini

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
[tox]
22
# Don't cover Python 3.7 since this is just a shim for that version. Do at
33
# least make sure we don't regress!
4-
envlist = {py27,py34,py35,py36}-{nocov,cov,diffcov},{py37,py38}-nocov,qa,docs
4+
envlist = {py27,py34,py35,py36}{,-cov,-diffcov},{py37,py38},qa,docs
55
skip_missing_interpreters = True
66

77

88
[testenv]
99
commands =
10-
nocov: python -m unittest discover
10+
!cov,!diffcov: python -m unittest discover
1111
cov,diffcov: python -m coverage run {[coverage]rc} -m unittest discover {posargs}
1212
cov,diffcov: python -m coverage combine {[coverage]rc}
1313
cov: python -m coverage html {[coverage]rc}

0 commit comments

Comments
 (0)