Skip to content

Allow triagers to close PRs if the PR is of very low quality #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 10, 2022
Merged

Allow triagers to close PRs if the PR is of very low quality #828

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d140165
Allow triagers to close PRs if the PR is of very low quality
AlexWaygood Apr 9, 2022
05d5ef9
Address reviews
AlexWaygood Apr 9, 2022
053ed11
Nit
AlexWaygood Apr 9, 2022
bc25768
Typo
AlexWaygood Apr 9, 2022
8b12561
Errant period
AlexWaygood Apr 9, 2022
f2166e7
Add Jelle's suggestion, make further misc revisions
AlexWaygood Apr 10, 2022
a81c52f
Update triaging.rst
AlexWaygood Apr 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions triaging.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,17 +35,31 @@ Responsibilities include:
- Good first issue
- Other categorizations

As triagers gain experience, they may have some intuition of when a PR should
be closed. Triagers can recommend closing a PR, but the final decision must be
made by a core developer. By having triagers and core developers work together,
Although triagers have the power to close PRs, they should generally not do so
without first consulting a core developer. By having triagers and core developers work together,
the author receives a careful consideration of their PR. This encourages future
contributions, regardless of whether their PR is accepted or closed.

Triagers can make use of the ``invalid`` and ``stale`` labels to suggest that a
Nonetheless, triagers should feel free to close a PR if they judge that the
chance of the PR being merged would be exceedingly low, even if substantial
revisions were made to the PR. This includes (but is not limited to) the
following:

* PRs proposing solely cosmetic changes
* PRs proposing changes to deprecated modules
* PRs that are no longer relevant. This includes:
- PRs proposing fixes for bugs that can no longer be reproduced
- PRs proposing changes that have been rejected by Python core developers
elsewhere (e.g. in an issue or a PEP rejection notice)

If a triager has any doubt about whether to close a PR, they should consult a core
developer before taking any action.

Triagers can also make use of the ``invalid`` and ``stale`` labels to suggest that a
PR may be suitable for closure. For more information, see the
:ref:`GitHub PR labels <github-pr-labels>` section.

It is also of paramount importance to treat every contributor to the Python
Note that it is of paramount importance to treat every contributor to the Python
project kindly and with respect. Regardless of whether they're entirely new
or a veteran core developer, they're actively choosing to voluntarily donate their
time towards the improvement of Python. As is the case with any member of
Expand Down