Skip to content

Commit 3bfa605

Browse files
AlexWaygoodhugovk
andauthored
Allow triagers to close PRs if the PR is of very low quality (#828)
As discussed on the CPython core-dev discord channel, there are several issues of the current policy that states that triagers should never close PRS: - Github's setup allows members of the triage team to close PRs, regardless of the policy stated in the devguide. - This policy isn't consistently followed by all members of the triage team. Some triagers occasionally close PRs (I have closed one or two myself in situations where it seemed abundantly clear that there was no prospect of the PR being merged). - This policy isn't really enforced in any way if triagers do close PRs. This lack of enforcement seems to be an implicit endorsement of the idea that it is okay for triagers to close PRs in some circumstances. - It feels silly to have to bother a core dev with a request for a PR to be closed if it's self-evident that it should be closed (e.g. if the PR makes changes to a deprecated module, makes solely cosmetic changes to a module, or simply has a 0% chance of ever being merged) - Changing this policy will help towards the goal of reducing the CPython PR backlog Co-authored-by: Hugo van Kemenade <[email protected]>
1 parent 0764536 commit 3bfa605

File tree

1 file changed

+19
-5
lines changed

1 file changed

+19
-5
lines changed

triaging.rst

Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,17 +35,31 @@ Responsibilities include:
3535
- Good first issue
3636
- Other categorizations
3737

38-
As triagers gain experience, they may have some intuition of when a PR should
39-
be closed. Triagers can recommend closing a PR, but the final decision must be
40-
made by a core developer. By having triagers and core developers work together,
38+
Although triagers have the power to close PRs, they should generally not do so
39+
without first consulting a core developer. By having triagers and core developers work together,
4140
the author receives a careful consideration of their PR. This encourages future
4241
contributions, regardless of whether their PR is accepted or closed.
4342

44-
Triagers can make use of the ``invalid`` and ``stale`` labels to suggest that a
43+
Nonetheless, triagers should feel free to close a PR if they judge that the
44+
chance of the PR being merged would be exceedingly low, even if substantial
45+
revisions were made to the PR. This includes (but is not limited to) the
46+
following:
47+
48+
* PRs proposing solely cosmetic changes
49+
* PRs proposing changes to deprecated modules
50+
* PRs that are no longer relevant. This includes:
51+
- PRs proposing fixes for bugs that can no longer be reproduced
52+
- PRs proposing changes that have been rejected by Python core developers
53+
elsewhere (e.g. in an issue or a PEP rejection notice)
54+
55+
If a triager has any doubt about whether to close a PR, they should consult a core
56+
developer before taking any action.
57+
58+
Triagers can also make use of the ``invalid`` and ``stale`` labels to suggest that a
4559
PR may be suitable for closure. For more information, see the
4660
:ref:`GitHub PR labels <github-pr-labels>` section.
4761

48-
It is also of paramount importance to treat every contributor to the Python
62+
Note that it is of paramount importance to treat every contributor to the Python
4963
project kindly and with respect. Regardless of whether they're entirely new
5064
or a veteran core developer, they're actively choosing to voluntarily donate their
5165
time towards the improvement of Python. As is the case with any member of

0 commit comments

Comments
 (0)