From bc069b0fffa484c5938cda41384fc031c89c11bb Mon Sep 17 00:00:00 2001 From: Serhiy Storchaka Date: Wed, 24 Aug 2022 15:07:20 +0300 Subject: [PATCH] gh-96021: Explicitly tear down the IsolatedAsyncioTestCase loop in tests (GH-96135) Tests for IsolatedAsyncioTestCase.debug() rely on the runner be closed in __del__. It makes tests depending on the GC an unreliable on other implementations. It is better to tear down the loop explicitly even if currently there is no a public API for this. (cherry picked from commit 4de06e3cc0a58d73934f9a2759ad9cd2f6b031b0) Co-authored-by: Serhiy Storchaka --- Lib/unittest/test/test_async_case.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Lib/unittest/test/test_async_case.py b/Lib/unittest/test/test_async_case.py index e46b99fd002648..b97ad939a0ea0d 100644 --- a/Lib/unittest/test/test_async_case.py +++ b/Lib/unittest/test/test_async_case.py @@ -14,10 +14,10 @@ def tearDownModule(): class TestAsyncCase(unittest.TestCase): maxDiff = None - def tearDown(self): + def setUp(self): # Ensure that IsolatedAsyncioTestCase instances are destroyed before # starting a new event loop - support.gc_collect() + self.addCleanup(support.gc_collect) def test_full_cycle(self): class Test(unittest.IsolatedAsyncioTestCase): @@ -108,6 +108,7 @@ async def on_cleanup(self): events = [] test = Test("test_func") + self.addCleanup(test._tearDownAsyncioLoop) try: test.debug() except MyException: @@ -143,6 +144,7 @@ async def on_cleanup(self): events = [] test = Test("test_func") + self.addCleanup(test._tearDownAsyncioLoop) try: test.debug() except MyException: @@ -178,6 +180,7 @@ async def on_cleanup(self): events = [] test = Test("test_func") + self.addCleanup(test._tearDownAsyncioLoop) try: test.debug() except MyException: @@ -219,6 +222,7 @@ async def on_cleanup2(self): events = [] test = Test("test_func") + self.addCleanup(test._tearDownAsyncioLoop) try: test.debug() except MyException: @@ -331,6 +335,7 @@ async def cleanup(self, fut): events = [] test = Test("test_func") + self.addCleanup(test._tearDownAsyncioLoop) try: test.debug() except MyException: