From bbeafa0627f2d69e3e9d75f87f02cf9123350ac3 Mon Sep 17 00:00:00 2001 From: Alexey Izbyshev Date: Wed, 12 Sep 2018 23:34:15 +0300 Subject: [PATCH] bpo-34649: Modules/_json.c: Add missing NULL checks to _encoded_const() Reported by Svace static analyzer. --- Modules/_json.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Modules/_json.c b/Modules/_json.c index 5a9464e34fb7f3..ac6e017a4eafc1 100644 --- a/Modules/_json.c +++ b/Modules/_json.c @@ -1374,7 +1374,7 @@ _encoded_const(PyObject *obj) if (s_null == NULL) { s_null = PyUnicode_InternFromString("null"); } - Py_INCREF(s_null); + Py_XINCREF(s_null); return s_null; } else if (obj == Py_True) { @@ -1382,7 +1382,7 @@ _encoded_const(PyObject *obj) if (s_true == NULL) { s_true = PyUnicode_InternFromString("true"); } - Py_INCREF(s_true); + Py_XINCREF(s_true); return s_true; } else if (obj == Py_False) { @@ -1390,7 +1390,7 @@ _encoded_const(PyObject *obj) if (s_false == NULL) { s_false = PyUnicode_InternFromString("false"); } - Py_INCREF(s_false); + Py_XINCREF(s_false); return s_false; } else {