From d79151d1f42cada3c8a409e6819cce0546d6e0cc Mon Sep 17 00:00:00 2001 From: Alexey Izbyshev Date: Wed, 22 Aug 2018 07:51:25 +0300 Subject: [PATCH] bpo-34456: pickle: Add missing NULL check to save_global(). (GH-8851) Reported by Svace static analyzer. (cherry picked from commit f8c06b028036e50596e75d4c9f6b27ba05133efe) Co-authored-by: Alexey Izbyshev --- Modules/_pickle.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Modules/_pickle.c b/Modules/_pickle.c index 10c8371d67408c..f5202f50c547f6 100644 --- a/Modules/_pickle.c +++ b/Modules/_pickle.c @@ -3349,6 +3349,8 @@ save_global(PicklerObject *self, PyObject *obj, PyObject *name) PickleState *st = _Pickle_GetGlobalState(); PyObject *reduce_value = Py_BuildValue("(O(OO))", st->getattr, parent, lastname); + if (reduce_value == NULL) + goto error; status = save_reduce(self, reduce_value, NULL); Py_DECREF(reduce_value); if (status < 0)