Skip to content

bpo-33907: Rename an IDLE module and class. #7807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 20, 2018

Conversation

terryjreedy
Copy link
Member

@terryjreedy terryjreedy commented Jun 20, 2018

Improve consistency and appearance. Module idlelib.calltips is now calltip.
Class idlelib.calltip_w.CallTip is now Calltip.

https://bugs.python.org/issue33907

@miss-islington
Copy link
Contributor

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-7808 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 20, 2018
Improve consistency and appearance. Module idlelib.calltips is now calltip.
Class idlelib.calltip_w.CallTip is now Calltip.
(cherry picked from commit 06e2029)

Co-authored-by: Terry Jan Reedy <[email protected]>
@miss-islington
Copy link
Contributor

Sorry, @terryjreedy, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 06e2029dfa500a42e3565ed7ba8573412f153d1c 3.6

miss-islington added a commit that referenced this pull request Jun 20, 2018
Improve consistency and appearance. Module idlelib.calltips is now calltip.
Class idlelib.calltip_w.CallTip is now Calltip.
(cherry picked from commit 06e2029)

Co-authored-by: Terry Jan Reedy <[email protected]>
terryjreedy added a commit to terryjreedy/cpython that referenced this pull request Jun 20, 2018
Improve consistency and appearance. Module idlelib.calltips is now calltip.
Class idlelib.calltip_w.CallTip is now Calltip..
(cherry picked from commit 06e2029)

Co-authored-by: Terry Jan Reedy <[email protected]>
@bedevere-bot
Copy link

GH-7809 is a backport of this pull request to the 3.6 branch.

terryjreedy added a commit that referenced this pull request Jun 20, 2018
Improve consistency and appearance. Module idlelib.calltips is now calltip.
Class idlelib.calltip_w.CallTip is now Calltip.
(cherry picked from commit 06e2029)

Co-authored-by: Terry Jan Reedy <[email protected]>
terryjreedy added a commit to terryjreedy/cpython that referenced this pull request Jun 20, 2018
Fixup class name duplication in PR python#7807.  Combined effect is that
module calltips and class calltips.Calltips are now calltip and
calltip.Calltip.  In module calltip_w class CallTip is now CalltipWindow.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 20, 2018
Fix-up class name duplication in PR pythonGH-7807. Combined effect is that
module calltips and its class CallTips are now calltip and Calltip.
In module calltip_w class CallTip is now CalltipWindow.
(cherry picked from commit 9af1836)

Co-authored-by: Terry Jan Reedy <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 20, 2018
Fix-up class name duplication in PR pythonGH-7807. Combined effect is that
module calltips and its class CallTips are now calltip and Calltip.
In module calltip_w class CallTip is now CalltipWindow.
(cherry picked from commit 9af1836)

Co-authored-by: Terry Jan Reedy <[email protected]>
terryjreedy added a commit that referenced this pull request Jun 20, 2018
Fix-up class name duplication in PR #7807. Combined effect is that
module calltips and its class CallTips are now calltip and Calltip.
In module calltip_w class CallTip is now CalltipWindow.
miss-islington added a commit that referenced this pull request Jun 20, 2018
Fix-up class name duplication in PR GH-7807. Combined effect is that
module calltips and its class CallTips are now calltip and Calltip.
In module calltip_w class CallTip is now CalltipWindow.
(cherry picked from commit 9af1836)

Co-authored-by: Terry Jan Reedy <[email protected]>
miss-islington added a commit that referenced this pull request Jun 20, 2018
Fix-up class name duplication in PR GH-7807. Combined effect is that
module calltips and its class CallTips are now calltip and Calltip.
In module calltip_w class CallTip is now CalltipWindow.
(cherry picked from commit 9af1836)

Co-authored-by: Terry Jan Reedy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants