From dfa3e510948499f210558120b0bf48b5d7e6db5f Mon Sep 17 00:00:00 2001 From: Zachary Ware Date: Tue, 13 Feb 2018 18:47:59 -0600 Subject: [PATCH 1/3] Use PYTHON_FOR_REGEN for clinic and blake2s_impl.c --- Makefile.pre.in | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/Makefile.pre.in b/Makefile.pre.in index f58b715378876a..2e710e1528f868 100644 --- a/Makefile.pre.in +++ b/Makefile.pre.in @@ -560,10 +560,9 @@ coverage-report: regen-grammar regen-importlib $(MAKE) coverage-lcov # Run "Argument Clinic" over all source files -# (depends on python having already been built) .PHONY=clinic -clinic: check-clean-src $(BUILDPYTHON) $(srcdir)/Modules/_blake2/blake2s_impl.c - $(RUNSHARED) $(PYTHON_FOR_BUILD) $(srcdir)/Tools/clinic/clinic.py --make --srcdir $(srcdir) +clinic: check-clean-src $(srcdir)/Modules/_blake2/blake2s_impl.c + $(PYTHON_FOR_REGEN) $(srcdir)/Tools/clinic/clinic.py --make --srcdir $(srcdir) # Build the interpreter $(BUILDPYTHON): Programs/python.o $(LIBRARY) $(LDLIBRARY) $(PY3LIBRARY) @@ -593,9 +592,9 @@ Modules/_math.o: Modules/_math.c Modules/_math.h $(CC) -c $(CCSHARED) $(PY_CORE_CFLAGS) -o $@ $< # blake2s is auto-generated from blake2b -$(srcdir)/Modules/_blake2/blake2s_impl.c: $(BUILDPYTHON) $(srcdir)/Modules/_blake2/blake2b_impl.c $(srcdir)/Modules/_blake2/blake2b2s.py - $(RUNSHARED) $(PYTHON_FOR_BUILD) $(srcdir)/Modules/_blake2/blake2b2s.py - $(RUNSHARED) $(PYTHON_FOR_BUILD) $(srcdir)/Tools/clinic/clinic.py -f $@ +$(srcdir)/Modules/_blake2/blake2s_impl.c: $(srcdir)/Modules/_blake2/blake2b_impl.c $(srcdir)/Modules/_blake2/blake2b2s.py + $(PYTHON_FOR_REGEN) $(srcdir)/Modules/_blake2/blake2b2s.py + $(PYTHON_FOR_REGEN) $(srcdir)/Tools/clinic/clinic.py -f $@ # Build the shared modules # Under GNU make, MAKEFLAGS are sorted and normalized; the 's' for From 03122044b030f5beb26ff731884f6e04798dbc31 Mon Sep 17 00:00:00 2001 From: Zachary Ware Date: Tue, 13 Feb 2018 18:48:36 -0600 Subject: [PATCH 2/3] Add clinic to regen-all --- Makefile.pre.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile.pre.in b/Makefile.pre.in index 2e710e1528f868..916f03091a00bc 100644 --- a/Makefile.pre.in +++ b/Makefile.pre.in @@ -732,7 +732,8 @@ regen-importlib: Programs/_freeze_importlib ############################################################################ # Regenerate all generated files -regen-all: regen-opcode regen-opcode-targets regen-typeslots regen-grammar regen-ast regen-importlib +regen-all: regen-opcode regen-opcode-targets regen-typeslots regen-grammar \ + regen-ast regen-importlib clinic ############################################################################ # Special rules for object files From 89c06d329dbf609831ecf5e65189b32cf8b600d6 Mon Sep 17 00:00:00 2001 From: Zachary Ware Date: Tue, 13 Feb 2018 18:53:02 -0600 Subject: [PATCH 3/3] Update .travis.yml for Makefile updates --- .travis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index dd0688717c0890..665b266146aec5 100644 --- a/.travis.yml +++ b/.travis.yml @@ -111,8 +111,7 @@ before_script: fi openssl version ./configure --with-pydebug - make -j4 - make -j4 regen-all clinic + make -j4 regen-all changes=`git status --porcelain` if ! test -z "$changes" then @@ -120,6 +119,7 @@ before_script: echo "$changes" exit 1 fi + make -j4 make pythoninfo script: