[3.10] bpo-38956: don't print BooleanOptionalAction's default twice (GH-27672) #27787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…H-27672) Co-authored-by: Micky Yun Chan <[email protected]> (cherry picked from commit 1512bc2) Co-authored-by: Maximilian Hils <[email protected]>
Contributor
Author
Contributor
Author
1 similar comment
Contributor
Author
ambv
reviewed
Aug 17, 2021
Contributor
ambv
left a comment
ambv
left a comment
There was a problem hiding this comment.
@pablogsal, this is a trivial fix for duplicated default values displayed in help for boolean options (added in 3.9.0). I intend to release that in 3.9.7 on August 30th.
There are more problems here that we could be fixing with larger refactors (see BPO-44587 for details) but this trivial change is a clear improvement over what we currently ship with.
|
|
||
| if help is not None and default is not None: | ||
| help += f" (default: {default})" | ||
| help += " (default: %(default)s)" |
Contributor
There was a problem hiding this comment.
@pablogsal, this works since the help string is treated as a formatting string (and presence of '%(default)' is detected). That way default display isn't duplicated.
pablogsal
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Micky Yun Chan [email protected]
(cherry picked from commit 1512bc2)
Co-authored-by: Maximilian Hils [email protected]
https://bugs.python.org/issue38956