closes bpo-42726: gdb libpython: InstanceProxy support for py3 #23912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fidget-Spinner
approved these changes
Dec 23, 2020
Member
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
There was a problem hiding this comment.
This LGTM other than one minor nit. Thanks!
I can't speak for the core devs, but my hunch is that we may need an issue and news entry :). Usually bugfixes get news entries, and the issue can help ping core devs interested in such issues.
hackaugusto
changed the title
hackaugusto
changed the title
benjaminp
reviewed
Dec 23, 2020
hackaugusto
force-pushed
the
gdb/libpython-instanceproxy-support-for-py3
branch
from
557efd0 to
d9c02f8
Compare
Contributor
Author
Created issue and added news entry |
hackaugusto
force-pushed
the
gdb/libpython-instanceproxy-support-for-py3
branch
from
d9c02f8 to
0e31076
Compare
benjaminp
changed the title
benjaminp
approved these changes
Dec 24, 2020
Contributor
|
@hackaugusto: Status check is done, and it's a failure ❌ . |
Contributor
|
@hackaugusto: Status check is done, and it's a success ✅ . |
Contributor
|
Thanks @hackaugusto for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 24, 2020
…nGH-23912) On Fedora 31 gdb is using python 3.7.9, calling `proxyval` on an instance with a dictionary fails because of the `dict.iteritems` usage. This PR changes the code to be compatible with py2 and py3. This changed seemed small enough to not need an issue and news blurb, if one is required please let me know. Automerge-Triggered-By: GH:benjaminp (cherry picked from commit b57ada9) Co-authored-by: Augusto Hack <[email protected]>
|
GH-23924 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 24, 2020
…nGH-23912) On Fedora 31 gdb is using python 3.7.9, calling `proxyval` on an instance with a dictionary fails because of the `dict.iteritems` usage. This PR changes the code to be compatible with py2 and py3. This changed seemed small enough to not need an issue and news blurb, if one is required please let me know. Automerge-Triggered-By: GH:benjaminp (cherry picked from commit b57ada9) Co-authored-by: Augusto Hack <[email protected]>
|
GH-23925 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
that referenced
this pull request
Dec 24, 2020
) On Fedora 31 gdb is using python 3.7.9, calling `proxyval` on an instance with a dictionary fails because of the `dict.iteritems` usage. This PR changes the code to be compatible with py2 and py3. This changed seemed small enough to not need an issue and news blurb, if one is required please let me know. Automerge-Triggered-By: GH:benjaminp (cherry picked from commit b57ada9) Co-authored-by: Augusto Hack <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Dec 24, 2020
) On Fedora 31 gdb is using python 3.7.9, calling `proxyval` on an instance with a dictionary fails because of the `dict.iteritems` usage. This PR changes the code to be compatible with py2 and py3. This changed seemed small enough to not need an issue and news blurb, if one is required please let me know. Automerge-Triggered-By: GH:benjaminp (cherry picked from commit b57ada9) Co-authored-by: Augusto Hack <[email protected]>
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
…nGH-23912) On Fedora 31 gdb is using python 3.7.9, calling `proxyval` on an instance with a dictionary fails because of the `dict.iteritems` usage. This PR changes the code to be compatible with py2 and py3. This changed seemed small enough to not need an issue and news blurb, if one is required please let me know. Automerge-Triggered-By: GH:benjaminp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Fedora 31 gdb is using python 3.7.9, calling
proxyvalon an instance with a dictionary fails because of thedict.iteritemsusage. This PR changes the code to be compatible with py2 and py3.This changed seemed small enough to not need an issue and news blurb, if one is required please let me know.
https://bugs.python.org/issue42726
Automerge-Triggered-By: GH:benjaminp