Skip to content

bpo-40221: Update multiprocessing to use _at_fork_reinit #19511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 2 commits into from
Apr 14, 2020
Merged

bpo-40221: Update multiprocessing to use _at_fork_reinit #19511

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7121b4a
bpo-40221: Update multiprocessing to use _at_fork_reinit
corona10 Apr 14, 2020
fe3f6e3
bpo-40221: Apply code review
corona10 Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions Lib/multiprocessing/queues.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ def __init__(self, maxsize=0, *, ctx):
self._sem = ctx.BoundedSemaphore(maxsize)
# For use by concurrent.futures
self._ignore_epipe = False

self._after_fork()
self._notempty = threading.Condition(threading.Lock())
self._reset()

if sys.platform != 'win32':
register_after_fork(self, Queue._after_fork)
Expand All @@ -63,11 +63,15 @@ def __getstate__(self):
def __setstate__(self, state):
(self._ignore_epipe, self._maxsize, self._reader, self._writer,
self._rlock, self._wlock, self._sem, self._opid) = state
self._after_fork()
self._notempty = threading.Condition(threading.Lock())
self._reset()

def _after_fork(self):
debug('Queue._after_fork()')
self._notempty = threading.Condition(threading.Lock())
self._notempty._at_fork_reinit()
self._reset()

def _reset(self):
self._buffer = collections.deque()
self._thread = None
self._jointhread = None
Expand Down
6 changes: 1 addition & 5 deletions Lib/multiprocessing/resource_sharer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ class _ResourceSharer(object):
def __init__(self):
self._key = 0
self._cache = {}
self._old_locks = []
self._lock = threading.Lock()
self._listener = None
self._address = None
Expand Down Expand Up @@ -113,10 +112,7 @@ def _afterfork(self):
for key, (send, close) in self._cache.items():
close()
self._cache.clear()
# If self._lock was locked at the time of the fork, it may be broken
# -- see issue 6721. Replace it without letting it be gc'ed.
self._old_locks.append(self._lock)
self._lock = threading.Lock()
self._lock._at_fork_reinit()
if self._listener is not None:
self._listener.close()
self._listener = None
Expand Down