From 4a0c16dd7bd19b457803a6e64d3f4be4bf8dfec4 Mon Sep 17 00:00:00 2001 From: Chris Eibl <138194463+chris-eibl@users.noreply.github.com> Date: Sat, 22 Feb 2025 07:24:24 +0100 Subject: [PATCH 1/2] fix compilation of mmap__sizeof__method for clang-cl --- Modules/mmapmodule.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Modules/mmapmodule.c b/Modules/mmapmodule.c index fcce7a6bd8c973..0f5418e1ffb36c 100644 --- a/Modules/mmapmodule.c +++ b/Modules/mmapmodule.c @@ -1094,7 +1094,7 @@ mmap__repr__method(PyObject *op) #ifdef MS_WINDOWS static PyObject * -mmap__sizeof__method(PyObject *op, void *Py_UNUSED(ignored)) +mmap__sizeof__method(PyObject *op, PyObject *Py_UNUSED(ignored)) { mmap_object *self = mmap_object_CAST(op); size_t res = _PyObject_SIZE(Py_TYPE(self)); From 04e1c7b46abb41893821716cc8337650ae922bae Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?B=C3=A9n=C3=A9dikt=20Tran?= <10796600+picnixz@users.noreply.github.com> Date: Sat, 22 Feb 2025 12:03:15 +0100 Subject: [PATCH 2/2] Apply suggestions from code review --- Modules/mmapmodule.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Modules/mmapmodule.c b/Modules/mmapmodule.c index 0f5418e1ffb36c..67fd6db2f361d6 100644 --- a/Modules/mmapmodule.c +++ b/Modules/mmapmodule.c @@ -1094,7 +1094,7 @@ mmap__repr__method(PyObject *op) #ifdef MS_WINDOWS static PyObject * -mmap__sizeof__method(PyObject *op, PyObject *Py_UNUSED(ignored)) +mmap__sizeof__method(PyObject *op, PyObject *Py_UNUSED(dummy)) { mmap_object *self = mmap_object_CAST(op); size_t res = _PyObject_SIZE(Py_TYPE(self));