Skip to content

gh-116932: Add notes on how to report python documentation theme bugs #117989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2024
Merged

gh-116932: Add notes on how to report python documentation theme bugs #117989

merged 1 commit into from
Apr 18, 2024

Conversation

lyc8503
Copy link
Contributor

@lyc8503 lyc8503 commented Apr 17, 2024 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir awaiting review labels Apr 17, 2024
@bedevere-app bedevere-app bot mentioned this pull request Apr 17, 2024
Closed
@encukou encukou merged commit 468b9ae into python:main Apr 18, 2024
@encukou
Copy link
Member

encukou commented Apr 18, 2024

Thank you!

@encukou encukou added the needs backport to 3.12 only security fixes label Apr 18, 2024
@miss-islington-app
Copy link

Thanks @lyc8503 for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@encukou encukou mentioned this pull request Apr 18, 2024
Closed
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 18, 2024
@lyc8503 @miss-islington
pythongh-116932: Add note on how to report python documentation theme…
d255e58 
… bugs (pythonGH-117989)

(cherry picked from commit 468b9ae)

Co-authored-by: lyc8503 <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Apr 18, 2024

GH-118031 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Apr 18, 2024
Privat33r-dev
Privat33r-dev reviewed Apr 18, 2024
View reviewed changes
Misc/NEWS.d/next/Documentation/2024-04-17-22-16-19.gh-issue-116932.lETyxa.rst
@@ -0,0 +1 @@
Add notes on how to report python documentation theme bugs
Copy link
Contributor

@Privat33r-dev Privat33r-dev Apr 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

News entry is not needed. But, I guess, it's a bit late now for this comment.

@Privat33r-dev
Copy link
Contributor

@AlexWaygood should the news entry be reverted?

encukou pushed a commit that referenced this pull request Apr 18, 2024
@miss-islington @lyc8503
[3.12] gh-116932: Add note on how to report python documentation them…
5af8fca 
…e bugs (GH-117989) (GH-118031)

gh-116932: Add note on how to report python documentation theme bugs (GH-117989)
(cherry picked from commit 468b9ae)

Co-authored-by: lyc8503 <[email protected]>
@AlexWaygood
Copy link
Member

@AlexWaygood should the news entry be reverted?

Meh. I probably wouldn't have included a news entry for this either, but I don't think it's the biggest issue in the world to have a single additional entry in an already-very-long changelog :-)

If you put up a PR to remove the news entry, I'd probably merge it... but I don't know that it would be the best use of your time ;-)

@lyc8503
Copy link
Contributor Author

lyc8503 commented Apr 18, 2024 via email •
edited
Loading

@lyc8503 lyc8503 mentioned this pull request Apr 18, 2024
Merged
@lyc8503 lyc8503 deleted the gh-116932 branch April 18, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Privat33r-dev Privat33r-dev Privat33r-dev left review comments

@encukou encukou encukou approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs (easy): Add reference to the Python docs theme gh repo
4 participants
@lyc8503 @encukou @Privat33r-dev @AlexWaygood