From 5c810cb2535c7a3d54d345b7eb1ebe068c95aabb Mon Sep 17 00:00:00 2001 From: Donghee Nals Date: Sat, 16 Mar 2024 19:39:38 +0900 Subject: [PATCH 1/5] gh-112536: Add more TSAN tests --- Lib/test/libregrtest/tsan.py | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/Lib/test/libregrtest/tsan.py b/Lib/test/libregrtest/tsan.py index 150fcec8816179..2cf41acb8c9dbf 100644 --- a/Lib/test/libregrtest/tsan.py +++ b/Lib/test/libregrtest/tsan.py @@ -2,20 +2,34 @@ # chosen because they use threads and run in a reasonable amount of time. TSAN_TESTS = [ + 'test_asyncio', + 'test_capi', 'test_code', + 'test_compileall', + 'test_concurrent_futures', 'test_enum', 'test_functools', + 'test_fork1', 'test_httpservers', 'test_imaplib', 'test_importlib', 'test_io', 'test_logging', + 'test_multiprocessing_forkserver', + 'test_multiprocessing_spawn', + 'test_pickle', + 'test_queue', + 'test_smtpnet', + 'test_socketserver', 'test_ssl', 'test_syslog', 'test_thread', 'test_threadedtempfile', + 'test_threading', 'test_threading_local', 'test_threadsignals', + 'test_urlib2net', + 'test_weakref', ] From fa2ad85d318c23fe2956d2729d1790a29d54c311 Mon Sep 17 00:00:00 2001 From: Donghee Nals Date: Sat, 16 Mar 2024 19:56:37 +0900 Subject: [PATCH 2/5] Reduce test --- Lib/test/libregrtest/tsan.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/Lib/test/libregrtest/tsan.py b/Lib/test/libregrtest/tsan.py index 2cf41acb8c9dbf..ecc1efaf694007 100644 --- a/Lib/test/libregrtest/tsan.py +++ b/Lib/test/libregrtest/tsan.py @@ -2,11 +2,9 @@ # chosen because they use threads and run in a reasonable amount of time. TSAN_TESTS = [ - 'test_asyncio', 'test_capi', 'test_code', 'test_compileall', - 'test_concurrent_futures', 'test_enum', 'test_functools', 'test_fork1', @@ -15,8 +13,6 @@ 'test_importlib', 'test_io', 'test_logging', - 'test_multiprocessing_forkserver', - 'test_multiprocessing_spawn', 'test_pickle', 'test_queue', 'test_smtpnet', @@ -28,7 +24,7 @@ 'test_threading', 'test_threading_local', 'test_threadsignals', - 'test_urlib2net', + 'test_urllib2net', 'test_weakref', ] From 427956bc7799f1780cb363e8712409dec980bd4d Mon Sep 17 00:00:00 2001 From: Donghee Nals Date: Sat, 16 Mar 2024 20:16:00 +0900 Subject: [PATCH 3/5] Reduce more tests --- Lib/test/libregrtest/tsan.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/Lib/test/libregrtest/tsan.py b/Lib/test/libregrtest/tsan.py index ecc1efaf694007..e860f26648bf7f 100644 --- a/Lib/test/libregrtest/tsan.py +++ b/Lib/test/libregrtest/tsan.py @@ -2,7 +2,6 @@ # chosen because they use threads and run in a reasonable amount of time. TSAN_TESTS = [ - 'test_capi', 'test_code', 'test_compileall', 'test_enum', @@ -21,7 +20,6 @@ 'test_syslog', 'test_thread', 'test_threadedtempfile', - 'test_threading', 'test_threading_local', 'test_threadsignals', 'test_urllib2net', From f9818870af090ff0f2929de215b0a17b5bc2e28b Mon Sep 17 00:00:00 2001 From: Donghee Nals Date: Sat, 16 Mar 2024 20:34:20 +0900 Subject: [PATCH 4/5] Exclude tests that network resources is needed --- Lib/test/libregrtest/tsan.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/Lib/test/libregrtest/tsan.py b/Lib/test/libregrtest/tsan.py index e860f26648bf7f..9ce0a44a01c5bb 100644 --- a/Lib/test/libregrtest/tsan.py +++ b/Lib/test/libregrtest/tsan.py @@ -14,15 +14,12 @@ 'test_logging', 'test_pickle', 'test_queue', - 'test_smtpnet', - 'test_socketserver', 'test_ssl', 'test_syslog', 'test_thread', 'test_threadedtempfile', 'test_threading_local', 'test_threadsignals', - 'test_urllib2net', 'test_weakref', ] From c624f64cf92d64da69480a51a8143cfe57d2088d Mon Sep 17 00:00:00 2001 From: Donghee Nals Date: Sat, 16 Mar 2024 21:03:24 +0900 Subject: [PATCH 5/5] Address code reivew --- Lib/test/libregrtest/tsan.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/Lib/test/libregrtest/tsan.py b/Lib/test/libregrtest/tsan.py index 9ce0a44a01c5bb..15e1b78dede818 100644 --- a/Lib/test/libregrtest/tsan.py +++ b/Lib/test/libregrtest/tsan.py @@ -3,16 +3,13 @@ TSAN_TESTS = [ 'test_code', - 'test_compileall', 'test_enum', 'test_functools', - 'test_fork1', 'test_httpservers', 'test_imaplib', 'test_importlib', 'test_io', 'test_logging', - 'test_pickle', 'test_queue', 'test_ssl', 'test_syslog',