Skip to content

gh-115405: add versionadded tag for co_qualname in code objects documentation #115411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2024
Merged

gh-115405: add versionadded tag for co_qualname in code objects documentation #115411

merged 1 commit into from
Feb 13, 2024

Conversation

@christophe-papazian
Copy link
Contributor

@christophe-papazian christophe-papazian commented Feb 13, 2024 •
edited by github-actions bot
Loading

Fix #115405

Usually documentation includes deprecated or "new in version" tags for all features.

the field co_qualname in code objects was added in python 3.11 but the documentation does not precise that, and it feels like it was always defined

https://docs.python.org/3/reference/datamodel.html#index-58

📚 Documentation preview 📚: https://cpython-previews--115411.org.readthedocs.build/

@ghost
Copy link

ghost commented Feb 13, 2024 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot mentioned this pull request Feb 13, 2024
Closed
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Feb 13, 2024
@AlexWaygood AlexWaygood self-assigned this Feb 13, 2024
@AlexWaygood
Copy link
Member

AlexWaygood commented Feb 13, 2024

Looks great, thanks! Screenshot of the build preview:

image

@AlexWaygood AlexWaygood added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Feb 13, 2024
@AlexWaygood AlexWaygood enabled auto-merge (squash) February 13, 2024 16:09
@AlexWaygood AlexWaygood merged commit de07941 into python:main Feb 13, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Feb 13, 2024

Thanks @christophe-papazian for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 13, 2024
@christophe-papazian @miss-islington
pythongh-115405: add versionadded tag for co_qualname in code objects…
56caa03 
… documentation (pythonGH-115411)

(cherry picked from commit de07941)

Co-authored-by: Christophe Papazian <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 13, 2024

GH-115412 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 13, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 13, 2024
@christophe-papazian @miss-islington
pythongh-115405: add versionadded tag for co_qualname in code objects…
66f2ce7 
… documentation (pythonGH-115411)

(cherry picked from commit de07941)

Co-authored-by: Christophe Papazian <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 13, 2024

GH-115413 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 13, 2024
AlexWaygood pushed a commit that referenced this pull request Feb 13, 2024
@miss-islington @christophe-papazian
[3.11] gh-115405: add versionadded tag for co_qualname in code object…
0af16e3 
…s documentation (GH-115411) (#115413)

gh-115405: add versionadded tag for co_qualname in code objects documentation (GH-115411)
(cherry picked from commit de07941)

Co-authored-by: Christophe Papazian <[email protected]>
AlexWaygood pushed a commit that referenced this pull request Feb 13, 2024
@miss-islington @christophe-papazian
[3.12] gh-115405: add versionadded tag for co_qualname in code object…
c2a3c3c 
…s documentation (GH-115411) (#115412)

gh-115405: add versionadded tag for co_qualname in code objects documentation (GH-115411)
(cherry picked from commit de07941)

Co-authored-by: Christophe Papazian <[email protected]>
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@christophe-papazian @fsc-eriker
pythongh-115405: add versionadded tag for co_qualname in code objects…
d201616 
… documentation (python#115411)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees

@AlexWaygood AlexWaygood

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

co_qualname "new in version" information missing in doc

2 participants

@christophe-papazian @AlexWaygood