From 4b0020fb0079617fc34ef939277c4d91a5f6a528 Mon Sep 17 00:00:00 2001 From: Sviatoslav Sydorenko Date: Wed, 31 May 2023 17:43:01 +0200 Subject: [PATCH 1/3] Revert "CI: Temporarily skip paths with spaces to avoid error (#105110)" This reverts commit 4c770617c0feae18ce3b05e0c8acd0910acc7082. --- .github/workflows/build.yml | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 8a42cdad7f3501..1d97c0a60928e3 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -87,20 +87,7 @@ jobs: with: filter: | Doc/** - # Temporarily skip paths with spaces - # (i.e. "C API", "Core and Builtins") - # to avoid "Error: One of your files includes a space". - # Pending https://github.com/python/core-workflow/issues/186 - # Misc/** - Misc/NEWS.d/next/Build/** - Misc/NEWS.d/next/Documentation/** - Misc/NEWS.d/next/IDLE/** - Misc/NEWS.d/next/Library/** - Misc/NEWS.d/next/Security/** - Misc/NEWS.d/next/Tests/** - Misc/NEWS.d/next/Tools-Demos/** - Misc/NEWS.d/next/Windows/** - Misc/NEWS.d/next/macOS/** + Misc/** .github/workflows/reusable-docs.yml - name: Check for docs changes if: >- From 9517c2171c5b4b432c055d80f8a431b713b7887e Mon Sep 17 00:00:00 2001 From: Sviatoslav Sydorenko Date: Wed, 31 May 2023 17:53:31 +0200 Subject: [PATCH 2/3] Use CSV-separated outputs @ get-changed-files @ CI This is necessary because paths with whitespaces tend to crash said action[[1]][[2]][[3]]. Also, we don't need to use JSON as it's harder to parse while the value isn't used except for the emptiness check. The change fixes [[4]] [1]: https://github.com/Ana06/get-changed-files#get-all-changed-files-as-space-delimited [2]: https://github.com/python/cpython/pull/103914#issuecomment-1570050722 [3]: https://github.com/python/cpython/pull/103914#issuecomment-1568507127 [4]: https://github.com/python/cpython/pull/103914#issuecomment-1568486285 --- .github/workflows/build.yml | 1 + .github/workflows/reusable-docs.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 1d97c0a60928e3..455202a9c01e37 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -89,6 +89,7 @@ jobs: Doc/** Misc/** .github/workflows/reusable-docs.yml + format: csv # unbreaks paths /w whitespaces; json is harder to parse - name: Check for docs changes if: >- github.event_name == 'pull_request' diff --git a/.github/workflows/reusable-docs.yml b/.github/workflows/reusable-docs.yml index 8a271e867c8b4d..831a49ad3e2719 100644 --- a/.github/workflows/reusable-docs.yml +++ b/.github/workflows/reusable-docs.yml @@ -40,6 +40,7 @@ jobs: uses: Ana06/get-changed-files@v2.2.0 with: filter: "Doc/**" + format: csv # unbreaks paths /w whitespaces; json is harder to parse - name: 'Build changed files in nit-picky mode' if: github.event_name == 'pull_request' continue-on-error: true From e140cd07fdf97f0c77c662a091c11eb4d7563b40 Mon Sep 17 00:00:00 2001 From: Sviatoslav Sydorenko Date: Wed, 31 May 2023 18:04:08 +0200 Subject: [PATCH 3/3] [DNM] Test change note addition --- .../next/C API/2023-05-31-18-03-29.gh-issue-105151.3SD5ns.rst | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 Misc/NEWS.d/next/C API/2023-05-31-18-03-29.gh-issue-105151.3SD5ns.rst diff --git a/Misc/NEWS.d/next/C API/2023-05-31-18-03-29.gh-issue-105151.3SD5ns.rst b/Misc/NEWS.d/next/C API/2023-05-31-18-03-29.gh-issue-105151.3SD5ns.rst new file mode 100644 index 00000000000000..e69de29bb2d1d6