Skip to content

[wasm32-emscripten] Emscripten node build is not portable to windows #96509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rchiodo opened this issue Sep 2, 2022 · 2 comments
Closed

[wasm32-emscripten] Emscripten node build is not portable to windows #96509

rchiodo opened this issue Sep 2, 2022 · 2 comments
Labels

Comments

@rchiodo
Copy link

rchiodo commented Sep 2, 2022

Bug report

Emscripten-node builds should be portable to other platforms. Copying an emscripten-build to a windows machine throws an error on startup:

Exception ignored error evaluating path:
Traceback (most recent call last):
  File "<frozen getpath>", line 268, in <module>
OSError: failed to make path absolute
Fatal Python error: error evaluating path

The root cause I believe is here:

#ifdef MS_WINDOWS

Emscripten builds don't define MS_WINDOWS (and they shouldn't) but the emscripten-node build has to be able to handle running on windows too.

Your environment

  • CPython versions tested on: Emscripten-node-debug build
  • Operating system and architecture: Windows 10 x64
@rchiodo rchiodo added the type-bug An unexpected behavior, bug, or error label Sep 2, 2022
@rchiodo
Copy link
Author

rchiodo commented Sep 2, 2022

I'd like to try fixing this if I can.

I was thinking there would be another #Ifdef for WASM and it would run both the posix checks and the windows checks for an absolute path.

I'm guessing there's more locations related to paths that don't port though.

@encukou
Copy link
Member

encukou commented Mar 25, 2024

Emscripten is now unsupported. I'll close this.
Like other Emscripten issues, it'll be listed on the GitHub project for anyone who wants to support the platform unofficially or bring support back.

@encukou encukou closed this as not planned Won't fix, can't repro, duplicate, stale Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

4 participants