Skip to content

Windows support for OpenSSL 3.0 #90728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jay0lee mannequin opened this issue Jan 29, 2022 · 3 comments
Closed

Windows support for OpenSSL 3.0 #90728

jay0lee mannequin opened this issue Jan 29, 2022 · 3 comments
Assignees
Labels
3.11 only security fixes 3.12 only security fixes build The build process and cross-build OS-windows topic-SSL type-feature A feature request or enhancement

Comments

@jay0lee
Copy link
Mannequin

jay0lee mannequin commented Jan 29, 2022

BPO 46570
Nosy @pfmoore, @tiran, @tjguk, @zware, @zooba

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/zooba'
closed_at = None
created_at = <Date 2022-01-29.13:35:11.638>
labels = ['expert-SSL', 'type-feature', 'OS-windows', 'build', '3.11']
title = 'Windows support for OpenSSL 3.0'
updated_at = <Date 2022-01-29.17:23:26.797>
user = 'https://bugs.python.org/jay0lee'

bugs.python.org fields:

activity = <Date 2022-01-29.17:23:26.797>
actor = 'christian.heimes'
assignee = 'steve.dower'
closed = False
closed_date = None
closer = None
components = ['Build', 'Windows', 'SSL']
creation = <Date 2022-01-29.13:35:11.638>
creator = 'jay0lee'
dependencies = []
files = []
hgrepos = []
issue_num = 46570
keywords = []
message_count = 2.0
messages = ['412072', '412085']
nosy_count = 6.0
nosy_names = ['paul.moore', 'christian.heimes', 'tim.golden', 'zach.ware', 'steve.dower', 'jay0lee']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'needs patch'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue46570'
versions = ['Python 3.11']

@jay0lee
Copy link
Mannequin Author

jay0lee mannequin commented Jan 29, 2022

Steps to reproduce:

  1. Compile OpenSSL 3.0 on Windows.
  2. use get_externals.bat to download Python external requirements on Windows.
  3. Overwrite OpenSSL 1.1.1m in externals with your OpenSSL 3.0 build.

Expected behavior:
Python will build against OpenSSL 3.0

Actual behavior:
Build fails with missing DLLs.

Further information:

  • For OpenSSL 3.0 builds, the first suffix for libcrypto and libssl is -3, not -1_1.
  • For x86_64 builds, there's also an -x64 suffix to distinguish from x86 builds.

I have a openssl.props modified file at:
https://github.com/GAM-team/actions-hello-world/blob/master/openssl.props

which I've overwritten the existing:
https://github.com/python/cpython/blob/main/PCbuild/openssl.props#L13

file with and then succesfully compiled against OpenSSL 3.0. However I'm not certain if or where the logic should exist to detect OpenSSL 3.0 DLLs instead of 1.1.

@jay0lee jay0lee mannequin added build The build process and cross-build 3.10 only security fixes labels Jan 29, 2022
@jay0lee jay0lee mannequin assigned tiran Jan 29, 2022
@jay0lee jay0lee mannequin added 3.11 only security fixes build The build process and cross-build topic-SSL 3.10 only security fixes labels Jan 29, 2022
@jay0lee jay0lee mannequin assigned tiran Jan 29, 2022
@jay0lee jay0lee mannequin added 3.11 only security fixes build The build process and cross-build topic-SSL labels Jan 29, 2022
@zware zware added OS-windows type-feature A feature request or enhancement and removed 3.10 only security fixes build The build process and cross-build labels Jan 29, 2022
@tiran
Copy link
Member

tiran commented Jan 29, 2022

OpenSSL 3.0 support is still experimental and incomplete. 3.10 is definitely out of scope. 3.11 might be feasible if somebody puts in the work.

@tiran tiran assigned zooba and unassigned tiran Jan 29, 2022
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
@ezio-melotti ezio-melotti moved this to Todo in OpenSSL 3 Jun 15, 2022
@gpshead gpshead added the 3.12 only security fixes label May 20, 2023
@zware
Copy link
Member

zware commented Jul 17, 2023

This is pretty much done via PRs connected to gh-99079.

@zware zware closed this as completed Jul 17, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in OpenSSL 3 Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.11 only security fixes 3.12 only security fixes build The build process and cross-build OS-windows topic-SSL type-feature A feature request or enhancement
Projects
Status: Done
Development

No branches or pull requests

4 participants