Skip to content

Unreadable dark theme syntax highlighting colors #118199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pochmann3 opened this issue Apr 23, 2024 · 6 comments
Closed

Unreadable dark theme syntax highlighting colors #118199

pochmann3 opened this issue Apr 23, 2024 · 6 comments
Labels
docs Documentation in the Doc dir

Comments

@pochmann3
Copy link
Contributor

Documentation

White on white is barely visible.

Only in 3.9 and lower, 3.10 and above are fine.

https://docs.python.org/3.9/library/functions.html#all

Screenshot_20240423-232545

@pochmann3 pochmann3 added the docs Documentation in the Doc dir label Apr 23, 2024
@terryjreedy
Copy link
Member

This appears to be a duplicate of #115349. A supposed fix was committed 2024-02-12&13 and should have been released as part of 3.8/9.19 on 2024-03-19. However, freshly accessed https://docs.python.org/3.8/library/functions.html says it is the 3.8.18, not 3.8.19 documentation. Ditto for https://docs.python.org/3.9/library/functions.html. Both continue to have the white-on-white problem illustrated above. The same is also true of the csv page, https://docs.python.org/3.8/library/csv.html, used to illustrate the previous issue.
@hugovk @ambv

@pochmann3
Copy link
Contributor Author

Right, duplicate. (I only searched for "color", not "colour", and only in open issues).

@terryjreedy terryjreedy changed the title Unreadable syntax highlighting colors Unreadable dark theme syntax highlighting colors Apr 24, 2024
@terryjreedy
Copy link
Member

I left this open as the followup to the closed but not completed issue. (And 'dark theme' is the search word here, which I added to the title.)

@hugovk
Copy link
Member

hugovk commented Apr 24, 2024

@JulienPalard Please can you check why the 3.8 and 3.9 security releases didn't trigger docs builds? And please can you start the builds?

@JulienPalard
Copy link
Member

3.8 done, rebuildling 3.9.

Build are not triggered automatically for security releases: https://github.com/python/docsbuild-scripts/blob/f0a570aec824c7d775ea9d345a89d1b10d0f11b2/build_docs.py#L159

@pochmann3
Copy link
Contributor Author

Ok now I'm still shown 3.9.18, but now it's readable. It's not dark mode anymore, but that seems to be the intended fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
None yet
Development

No branches or pull requests

4 participants