Skip to content

Speedup os.path #117609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nineteendo opened this issue Apr 7, 2024 · 4 comments
Closed

Speedup os.path #117609

nineteendo opened this issue Apr 7, 2024 · 4 comments
Labels
performance Performance or resource usage stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@nineteendo
Copy link
Contributor

nineteendo commented Apr 7, 2024

Feature or enhancement

Proposal:

There are (still) some minor optimisations possible in os.path, including some fast returns.

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs

@nineteendo nineteendo added the type-feature A feature request or enhancement label Apr 7, 2024
@Eclips4 Eclips4 added performance Performance or resource usage stdlib Python modules in the Lib dir labels Apr 7, 2024
@barneygale
Copy link
Contributor

Duplicate of #117349, please don't do this. The bug tracker is not your personal to-do list.

@barneygale barneygale closed this as not planned Won't fix, can't repro, duplicate, stale Apr 8, 2024
@nineteendo
Copy link
Contributor Author

Most PRs will require an issue number. Trivial changes, like fixing a typo, do not need an issue.

Must I link to the closed issue then? This PR is about further changes.

@barneygale
Copy link
Contributor

barneygale commented Apr 8, 2024

If you think the previous issue was closed prematurely then you can leave a comment there asking for it to be re-opened.

Please take a look at other issues on the bug tracker to get an idea of what's in and out of scope. We don't generally allow issues like "micro-optimise this entire module" - they're too broad and not useful enough to other developers.

@nineteendo
Copy link
Contributor Author

If you think the previous issue was closed prematurely then you can leave a comment there asking for it to be re-opened.

Not prematurely, I just found new optimisations.

We don't generally allow issues like "micro-optimise this entire module"

There is a particularly inefficient loop in ntpath: #117610 (comment)
Can I add some other optimisations alongside it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance or resource usage stdlib Python modules in the Lib dir type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

3 participants