Skip to content

Provide standard infrastructure for clearing global caches #102080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
corona10 opened this issue Feb 20, 2023 · 6 comments
Open

Provide standard infrastructure for clearing global caches #102080

corona10 opened this issue Feb 20, 2023 · 6 comments
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@corona10
Copy link
Member

It turns out that some global caches have memory leak issues while the refleak CI is running.
The global cache is not the problem, but we must provide a better solution to clear them after the tests.

Suggestion from @gvanrossum: #101988 (review)

@corona10 corona10 added the type-feature A feature request or enhancement label Feb 20, 2023
@corona10
Copy link
Member Author

cc @sobolevn

@gvanrossum
Copy link
Member

Look hard, I think there is test infra code that handles a bunch of these. @JelleZijlstra ?

@sobolevn
Copy link
Member

I know this cache-related helper:

def clear_caches():

@JelleZijlstra
Copy link
Member

Thanks Nikita, I was just looking for that too.

I'm not sure we need any other general mechanism. If there's anything missing from libregrtest.utils.clear_caches, we should simply add it.

@gvanrossum
Copy link
Member

That's the one I remembered.

@corona10
Copy link
Member Author

Looks like #101988 should be ported to use libregrtest.utils.clear_caches
I will submit the patch soon.

@iritkatriel iritkatriel added the tests Tests in the Lib/test dir label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

5 participants