Skip to content

Commit f9ff0bf

Browse files
bpo-41682: fixed flaky test test_sendfile_close_peer_in_the_middle_of_receiving (GH-30845) (#30861)
(cherry picked from commit 1c705fd) Co-authored-by: Kumar Aditya <[email protected]> Co-authored-by: Kumar Aditya <[email protected]>
1 parent b0b8388 commit f9ff0bf

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

Lib/test/test_asyncio/test_sendfile.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,13 @@ async def wait_closed(self):
8787

8888
class SendfileBase:
8989

90-
# 128 KiB plus small unaligned to buffer chunk
91-
DATA = b"SendfileBaseData" * (1024 * 8 + 1)
92-
90+
# 256 KiB plus small unaligned to buffer chunk
91+
# Newer versions of Windows seems to have increased its internal
92+
# buffer and tries to send as much of the data as it can as it
93+
# has some form of buffering for this which is less than 256KiB
94+
# on newer server versions and Windows 11.
95+
# So DATA should be larger than 256 KiB to make this test reliable.
96+
DATA = b"x" * (1024 * 256 + 1)
9397
# Reduce socket buffer size to test on relative small data sets.
9498
BUF_SIZE = 4 * 1024 # 4 KiB
9599

@@ -451,8 +455,6 @@ def test_sendfile_ssl_close_peer_after_receiving(self):
451455
# themselves).
452456
@unittest.skipIf(sys.platform.startswith('sunos'),
453457
"Doesn't work on Solaris")
454-
@unittest.skipIf(sys.platform == "win32",
455-
"It is flaky on Windows and needs to be fixed") # TODO: bpo-41682
456458
def test_sendfile_close_peer_in_the_middle_of_receiving(self):
457459
srv_proto, cli_proto = self.prepare_sendfile(close_after=1024)
458460
with self.assertRaises(ConnectionError):

0 commit comments

Comments
 (0)