Skip to content

Commit f2a10a1

Browse files
committed
Show full result if it's not all zeros
1 parent 0dd589e commit f2a10a1

File tree

1 file changed

+13
-7
lines changed

1 file changed

+13
-7
lines changed

Lib/test/libregrtest/refleak.py

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ def get_pooled_int(value):
8989

9090
if not quiet:
9191
print("beginning", repcount, "repetitions. Showing number of leaks "
92-
"(. for zero, X for 10 or more)",
92+
"(. for 0 or less, X for 10 or more)",
9393
file=sys.stderr)
9494
numbers = ("1234567890"*(repcount//10 + 1))[:repcount]
9595
numbers = numbers[:warmups] + ':' + numbers[warmups:]
@@ -175,14 +175,20 @@ def check_fd_deltas(deltas):
175175
]:
176176
# ignore warmup runs
177177
deltas = deltas[warmups:]
178-
if checker(deltas):
178+
failing = checker(deltas)
179+
suspicious = any(deltas)
180+
if failing or suspicious:
179181
msg = '%s leaked %s %s, sum=%s' % (
180182
test_name, deltas, item_name, sum(deltas))
181-
print(msg, file=sys.stderr, flush=True)
182-
with open(filename, "a", encoding="utf-8") as refrep:
183-
print(msg, file=refrep)
184-
refrep.flush()
185-
failed = True
183+
print(msg, end='', file=sys.stderr)
184+
if failing:
185+
print(file=sys.stderr, flush=True)
186+
with open(filename, "a", encoding="utf-8") as refrep:
187+
print(msg, file=refrep)
188+
refrep.flush()
189+
failed = True
190+
else:
191+
print(' (this is fine)', file=sys.stderr, flush=True)
186192
return (failed, results)
187193

188194

0 commit comments

Comments
 (0)