Skip to content

Commit e55cf02

Browse files
taleinatterryjreedy
authored andcommitted
bpo-35730: IDLE - test squeezer reload() by checking load_font() (GH-11585)
1 parent cf27c06 commit e55cf02

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

Lib/idlelib/idle_test/test_squeezer.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -293,25 +293,21 @@ def test_squeeze_text_before_existing_squeezed_text(self):
293293
def test_reload(self):
294294
"""Test the reload() class-method."""
295295
editwin = self.make_mock_editor_window(with_text_widget=True)
296-
text_widget = editwin.text
297296
squeezer = self.make_squeezer_instance(editwin)
297+
squeezer.load_font = Mock()
298298

299-
orig_zero_char_width = squeezer.zero_char_width
300299
orig_auto_squeeze_min_lines = squeezer.auto_squeeze_min_lines
301300

302-
# Increase both font size and auto-squeeze-min-lines.
303-
text_widget["font"] = ('Courier', 20)
301+
# Increase auto-squeeze-min-lines.
304302
new_auto_squeeze_min_lines = orig_auto_squeeze_min_lines + 10
305303
self.set_idleconf_option_with_cleanup(
306304
'main', 'PyShell', 'auto-squeeze-min-lines',
307305
str(new_auto_squeeze_min_lines))
308306

309307
Squeezer.reload()
310-
# The following failed on Gentoo buildbots. Issue title will be
311-
# IDLE: Fix squeezer test_reload.
312-
#self.assertGreater(squeezer.zero_char_width, orig_zero_char_width)
313308
self.assertEqual(squeezer.auto_squeeze_min_lines,
314309
new_auto_squeeze_min_lines)
310+
squeezer.load_font.assert_called()
315311

316312
def test_reload_no_squeezer_instances(self):
317313
"""Test that Squeezer.reload() runs without any instances existing."""

0 commit comments

Comments
 (0)