Skip to content

Commit d336b1c

Browse files
authored
bpo-11617: Try to strengthen test_httpservers (GH-11121)
(cherry picked from commit cb34218)
1 parent d0d09b5 commit d336b1c

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Lib/test/test_httpservers.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ def __init__(self, test_object, request_handler):
5555
self.test_object = test_object
5656

5757
def run(self):
58-
self.server = HTTPServer(('', 0), self.request_handler)
59-
self.test_object.PORT = self.server.socket.getsockname()[1]
58+
self.server = HTTPServer(('localhost', 0), self.request_handler)
59+
self.test_object.HOST, self.test_object.PORT = self.server.socket.getsockname()
6060
self.test_object.server_started.set()
6161
self.test_object = None
6262
try:
@@ -84,7 +84,7 @@ def tearDown(self):
8484
test_support.threading_cleanup(*self._threads)
8585

8686
def request(self, uri, method='GET', body=None, headers={}):
87-
self.connection = httplib.HTTPConnection('localhost', self.PORT)
87+
self.connection = httplib.HTTPConnection(self.HOST, self.PORT)
8888
self.connection.request(method, uri, body, headers)
8989
return self.connection.getresponse()
9090

@@ -187,7 +187,7 @@ def do_HEAD(self):
187187

188188
def setUp(self):
189189
BaseTestCase.setUp(self)
190-
self.con = httplib.HTTPConnection('localhost', self.PORT)
190+
self.con = httplib.HTTPConnection(self.HOST, self.PORT)
191191
self.con.connect()
192192

193193
def test_command(self):

0 commit comments

Comments
 (0)