Free arena on _PyCompile_AstOptimize failure in Py_CompileStringObject (GH-127910)

berkerpeksag · web-flow · commit cfeaa992ba9b · 2024-12-16T22:59:36.000+02:00
After commit 10a91d7 introduced arena cleanup, commit 2dfbd4f removed the free call when _PyCompile_AstOptimize fails.
diff --git a/Python/pythonrun.c b/Python/pythonrun.c
@@ -1486,6 +1486,7 @@ Py_CompileStringObject(const char *str, PyObject *filename, int start,
     if (flags && (flags->cf_flags & PyCF_ONLY_AST)) {
         if ((flags->cf_flags & PyCF_OPTIMIZED_AST) == PyCF_OPTIMIZED_AST) {
             if (_PyCompile_AstOptimize(mod, filename, flags, optimize, arena) < 0) {
+                _PyArena_Free(arena);
                 return NULL;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -1486,6 +1486,7 @@ Py_CompileStringObject(const char str, PyObject filename, int start,`
`1486`	`1486`	`if (flags && (flags->cf_flags & PyCF_ONLY_AST)) {`
`1487`	`1487`	`if ((flags->cf_flags & PyCF_OPTIMIZED_AST) == PyCF_OPTIMIZED_AST) {`
`1488`	`1488`	`if (_PyCompile_AstOptimize(mod, filename, flags, optimize, arena) < 0) {`
	`1489`	`+ _PyArena_Free(arena);`
`1489`	`1490`	`return NULL;`
`1490`	`1491`	`}`
`1491`	`1492`	`}`