Skip to content

Commit a1725b4

Browse files
committed
Address review
1 parent fe0dad3 commit a1725b4

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

Tools/wasm/mypy.ini

+2-3
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,5 @@ python_version = 3.8
1010
strict = True
1111
enable_error_code = truthy-bool,ignore-without-code
1212

13-
# except for a few settings that can't yet be enabled:
14-
warn_return_any = False
15-
warn_unreachable = False
13+
# except for incomplete defs, which are useful for module authors:
14+
disallow_incomplete_defs = False

Tools/wasm/wasm_assets.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,8 @@ def get_builddir(args: argparse.Namespace) -> pathlib.Path:
111111

112112
def get_sysconfigdata(args: argparse.Namespace) -> pathlib.Path:
113113
"""Get path to sysconfigdata relative to build root"""
114-
data_name = sysconfig._get_sysconfigdata_name() # type: ignore[attr-defined]
114+
assert isinstance(args.builddir, pathlib.Path)
115+
data_name: str = sysconfig._get_sysconfigdata_name() # type: ignore[attr-defined]
115116
if not data_name.startswith(SYSCONFIG_NAMES):
116117
raise ValueError(
117118
f"Invalid sysconfig data name '{data_name}'.", SYSCONFIG_NAMES

0 commit comments

Comments
 (0)