Skip to content

Commit 96fb350

Browse files
miss-islingtonlysnikolaou
authored andcommitted
bpo-21263: Skip test_gdb when python has been compiled with LLVM clang (GH-10318) (GH-10325)
(cherry picked from commit 59668aa) Co-authored-by: Lysandros Nikolaou <[email protected]>
1 parent 133fd65 commit 96fb350

File tree

3 files changed

+10
-0
lines changed

3 files changed

+10
-0
lines changed

Lib/test/test_gdb.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
import locale
77
import os
8+
import platform
89
import re
910
import subprocess
1011
import sys
@@ -48,6 +49,10 @@ def get_gdb_version():
4849
if not sysconfig.is_python_build():
4950
raise unittest.SkipTest("test_gdb only works on source builds at the moment.")
5051

52+
if 'Clang' in platform.python_compiler() and sys.platform == 'darwin':
53+
raise unittest.SkipTest("test_gdb doesn't work correctly when python is"
54+
" built with LLVM clang")
55+
5156
# Location of custom hooks file in a repository checkout.
5257
checkout_hook_path = os.path.join(os.path.dirname(sys.executable),
5358
'python-gdb.py')

Misc/ACKS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1136,6 +1136,7 @@ Samuel Nicolary
11361136
Jonathan Niehof
11371137
Gustavo Niemeyer
11381138
Oscar Nierstrasz
1139+
Lysandros Nikolaou
11391140
Hrvoje Nikšić
11401141
Gregory Nofi
11411142
Jesse Noller
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
After several reports that test_gdb does not work properly on macOS and
2+
since gdb is not shipped by default anymore, test_gdb is now skipped on
3+
macOS when LLVM Clang has been used to compile Python. Patch by
4+
Lysandros Nikolaou

0 commit comments

Comments
 (0)