Skip to content

Commit 8abc3f4

Browse files
tiranmiss-islington
authored andcommitted
bpo-36577: setup.py reports missing OpenSSL again (GH-12746)
[bpo-36146](https://bugs.python.org/issue36146) introduced another regression. In case of missing OpenSSL libraries or headers, setup.py no longer reported _hashlib and _ssl to be missing. Signed-off-by: Christian Heimes <[email protected]> https://bugs.python.org/issue36577
1 parent bb44478 commit 8abc3f4

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
setup.py now correctly reports missing OpenSSL headers and libraries again.

setup.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2153,13 +2153,15 @@ def split_var(name, sep):
21532153
openssl_libs = split_var('OPENSSL_LIBS', '-l')
21542154
if not openssl_libs:
21552155
# libssl and libcrypto not found
2156+
self.missing.extend(['_ssl', '_hashlib'])
21562157
return None, None
21572158

21582159
# Find OpenSSL includes
21592160
ssl_incs = find_file(
21602161
'openssl/ssl.h', self.inc_dirs, openssl_includes
21612162
)
21622163
if ssl_incs is None:
2164+
self.missing.extend(['_ssl', '_hashlib'])
21632165
return None, None
21642166

21652167
# OpenSSL 1.0.2 uses Kerberos for KRB5 ciphers

0 commit comments

Comments
 (0)