Skip to content

Commit 83ad40e

Browse files
authored
bpo-44434: Don't call PyThread_exit_thread() explicitly (GH-26758) (GH-26825)
_thread.start_new_thread() no longer calls PyThread_exit_thread() explicitly at the thread exit, the call was redundant. On Linux with the glibc, pthread_cancel() loads dynamically the libgcc_s.so.1 library. dlopen() can fail if there is no more available file descriptor to open the file. In this case, the process aborts with the error message: "libgcc_s.so.1 must be installed for pthread_cancel to work" pthread_cancel() unwinds back to the thread's wrapping function that calls the thread entry point. The unwind function is dynamically loaded from the libgcc_s library since it is tightly coupled to the C compiler (GCC). The unwinder depends on DWARF, the compiler generates DWARF, so the unwinder belongs to the compiler. Thanks Florian Weimer and Carlos O'Donell for their help on investigating this issue. (cherry picked from commit 45a78f9)
1 parent 175e264 commit 83ad40e

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
_thread.start_new_thread() no longer calls PyThread_exit_thread() explicitly
2+
at the thread exit, the call was redundant. On Linux with the glibc,
3+
pthread_exit() aborts the whole process if dlopen() fails to open
4+
libgcc_s.so file (ex: EMFILE error). Patch by Victor Stinner.

Modules/_threadmodule.c

+4-1
Original file line numberDiff line numberDiff line change
@@ -1056,7 +1056,10 @@ t_bootstrap(void *boot_raw)
10561056
tstate->interp->num_threads--;
10571057
PyThreadState_Clear(tstate);
10581058
_PyThreadState_DeleteCurrent(tstate);
1059-
PyThread_exit_thread();
1059+
1060+
// bpo-44434: Don't call explicitly PyThread_exit_thread(). On Linux with
1061+
// the glibc, pthread_exit() can abort the whole process if dlopen() fails
1062+
// to open the libgcc_s.so library (ex: EMFILE error).
10601063
}
10611064

10621065
static PyObject *

0 commit comments

Comments
 (0)